<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113519/">http://git.reviewboard.kde.org/r/113519/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Yuri Samoilenko.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2013, 9:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Storing/restoring settings through WorkflowMngr implemented.
Tested:
1. renaming, batch processing without ExtenalTools
- one queue
- two queues
- using multiple cores
2. renaming, batch processing with ExtenalTools
- one queue
- two queues with diffrent external tool
- using multiple cores
BUG: "Target Album" in Target tab is not working in master branch(without ET) when two or more queue present - all processed pictures puts in last selected album.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
digikam
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is my first review. I have some questions about direction of my work.
The core of the patch in moving Queue processing internals out of overburdened QueueMgrWindow to simple QueueMgr.
QueueMgr responsible for procession only one queue from begining to the end. To implement "group-file-passing-to-extrenal-tool" QueueMgr intercept all signals from underlying taksk and and composing "result url list" which will be sended to external tool in the end.
Configuring of External Tools impemented in new tab in BQM QueueSettings and selecting tool for current processing int "Target" tab in BQM QueueSettings.
There is no interaction within "External Tools" and "Target Album" in Target tab yet.
Any comments?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>utilities/queuemanager/CMakeLists.txt <span style="color: grey">(910752c)</span></li>
<li>utilities/queuemanager/main/etrunner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/main/etrunner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/main/etwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/main/etwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/main/etwidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/main/queuemgr.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/main/queuemgr.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>utilities/queuemanager/main/queuemgrwindow.cpp <span style="color: grey">(8cd65bd)</span></li>
<li>utilities/queuemanager/main/queuemgrwindow_p.h <span style="color: grey">(7bf44da)</span></li>
<li>utilities/queuemanager/manager/queuesettings.h <span style="color: grey">(522c46f)</span></li>
<li>utilities/queuemanager/manager/task.cpp <span style="color: grey">(d825380)</span></li>
<li>utilities/queuemanager/manager/workflowmanager.cpp <span style="color: grey">(f7da540)</span></li>
<li>utilities/queuemanager/views/queuesettingsview.cpp <span style="color: grey">(d9b89b3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113519/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>