[Digikam-devel] Review Request 109017: Add Olympus' LensModel to DMetadata

[Teemu Rytilahti]

> On March 21, 2013, 4:29 a.m., Gilles Caulier wrote:
> > I responded to this entry:
> > 
> > https://git.reviewboard.kde.org/r/109048/
> > 
> > ... and i never see this one.
> > 
> > 109048 can be considerated as obsolete and replaced by this one ?

No, these two are completely separate patches. This patch adds support to read the LensModel from Olympus-specific tag (also adds commented out version, in case it is needed at some point). Before this patch the properties of the image didn't show the lens at all for me, nor was it handled to Lensfun plugin either. (see attached screenshot)

The "encrypted" part of LensType was fixed earlier this year, but it gives different input (and thus I reverted to use LensModel, as it is similar to what Lensfun uses in my case at least). Example output from exiv2:
[tpr at tuli epl]$ exiv2 -pa P2211096.ORF|grep LensTy
Exif.OlympusEq.LensType                      Byte        6  Olympus M.Zuiko Digital 14-42mm F3.5-5.6 II
[tpr at tuli epl]$ exiv2 -pa P2211096.ORF|grep LensModel
Exif.OlympusEq.LensModel                     Ascii      32  OLYMPUS M.14-42mm F3.5-5.6 II


- Teemu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109017/#review29611
-----------------------------------------------------------


On March 21, 2013, 2:11 p.m., Teemu Rytilahti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109017/
> -----------------------------------------------------------
> 
> (Updated March 21, 2013, 2:11 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Description
> -------
> 
> This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.
> 
> 
> This addresses bug 311295.
>     http://bugs.kde.org/show_bug.cgi?id=311295
> 
> 
> Diffs
> -----
> 
>   libs/dmetadata/dmetadata.cpp 8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9 
> 
> Diff: http://git.reviewboard.kde.org/r/109017/diff/
> 
> 
> Testing
> -------
> 
> Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.
> 
> 
> File Attachments
> ----------------
> 
> Properties bar showing the lens information
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/03/21/lens.png
> 
> 
> Thanks,
> 
> Teemu Rytilahti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130321/af9050b8/attachment.html>