<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109017/">http://git.reviewboard.kde.org/r/109017/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 21st, 2013, 4:29 a.m. UTC, <b>Gilles Caulier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I responded to this entry:
https://git.reviewboard.kde.org/r/109048/
... and i never see this one.
109048 can be considerated as obsolete and replaced by this one ?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, these two are completely separate patches. This patch adds support to read the LensModel from Olympus-specific tag (also adds commented out version, in case it is needed at some point). Before this patch the properties of the image didn't show the lens at all for me, nor was it handled to Lensfun plugin either. (see attached screenshot)
The "encrypted" part of LensType was fixed earlier this year, but it gives different input (and thus I reverted to use LensModel, as it is similar to what Lensfun uses in my case at least). Example output from exiv2:
[tpr@tuli epl]$ exiv2 -pa P2211096.ORF|grep LensTy
Exif.OlympusEq.LensType Byte 6 Olympus M.Zuiko Digital 14-42mm F3.5-5.6 II
[tpr@tuli epl]$ exiv2 -pa P2211096.ORF|grep LensModel
Exif.OlympusEq.LensModel Ascii 32 OLYMPUS M.14-42mm F3.5-5.6 II</pre>
<br />
<p>- Teemu</p>
<br />
<p>On March 21st, 2013, 2:11 p.m. UTC, Teemu Rytilahti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Teemu Rytilahti.</div>
<p style="color: grey;"><i>Updated March 21, 2013, 2:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for Olympus lenses adding Exif.OlympusEq.LensModel to the list of tags to search for the lens model. This allows Digikam to detect the lens for Lensfun and for the properties bar. More information available on bug entry.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested by running tests/testlensfuniface and also starting the lensfun tool inside Digikam. Also tested to re-read the metadata from files and checked that it's displayed in properties bar.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311295">311295</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/dmetadata/dmetadata.cpp <span style="color: grey">(8eccb453731b8013c9cecf5f07bfa1bcbd6dd4c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109017/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/03/21/lens.png">Properties bar showing the lens information</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>