[Digikam-devel] Does current git compile with KDE SC 4.10's kdegrphics libs?

[Gilles Caulier]

This is my response from private mail with Veaceslav :

I think you don't need to back-port you patch in libkexiv2 from KDE 4.10
branch... In fact you cannot back-port your patch and KDE 4.10 must
preserve binary compatibility. Your patch break BC due to new methods add
in library

Don't forget that libkexiv2 is hosted in kdegraphics, which is a KDE
component, released officially with KDE. Sure digiKam, because it's don't
release at the same KDE time, it include last libkexiv2 code, but packagers
can disable to use this library from digiKam tarball and
use official libkexiv2 from KDE instead.

This is the same workflow from libkipi and libkdcraw.

Currently, your patch from libkexiv2 will be included with KDE 4.11. To be
sure that digiKam can be compiled with libkexiv2 from KDE 4.10, you need to
wrap your code from Digikam::DMetadata class into conditional pre-processor
rules, checking libkexiv2 version ID shared with libkexiv2/version.h. It's
very easy to do...

Gilles


2013/3/4 Veaceslav Munteanu <slavuttici at gmail.com>

> On Sun, Mar 3, 2013 at 10:49 PM, Marcel Wiesweg <marcel.wiesweg at gmx.de>
> wrote:
> >
> >
> >> Please use the private libs, new version of libkexiv2 is comming with
> >> KDE 4.10.2 and we operated few changes on this lib.
> >
> > Did you really backport this change to the 4.10 branch? I'm not sure
> this is
> > really appropriate, it's a new feature, not a fix.
>
> Marcel, I don't understand...
>
> I changes in libkexiv2 are needed for writting picassa faces and as
> Gilles suggested I increased API/ABI count of the libkexiv.
> Also I began to commit some pieces of code that is tested and work,
> because implementing rotations, I touch to much files so I will get a
> too big to review patch...If you want I can roll back the changes that
> won't make digikam not to compile with shared libkexiv...
>
>
> --
> Veaceslav
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130304/b30cddf5/attachment.html>