[Digikam-devel] Review Request 108574: Turned on sorting by pixel size and added sorting by aspect ratio

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108574/#review26352
-----------------------------------------------------------


Stephen,

I review your patch, apply it to current git/master implementation, and tested.

Where options are available in Setup to show aspect ratio properly on thumbnails view and tool-tips, i cannot see any option in Filters tab from Right side-bar to sort items by aspect ratio.

As you said in this entry description, this patch much add this feature... Or i forget something ?

http://www.flickr.com/photos/digikam/8425632063/sizes/o/in/photostream/

Note : if you use text Filter to sort items from icon view by aspect ratio, well where is the option in drop-down list available on the right of search text field ?

Another important point, the capability to find items by aspect ratio in Advanced Search dialog, through "Picture Properties" section. Here, again, no option are available. To be homogeneous, search by aspect ratio must be available too...

In all case, these entries from bugzilla must be closed when your patch will be ap^plied to git/master (after 3.0.0 release planed on 6 February):

https://bugs.kde.org/show_bug.cgi?id=121313

https://bugs.kde.org/show_bug.cgi?id=224549

Gilles Caulier




- Gilles Caulier


On Jan. 28, 2013, 3:46 p.m., Stephen Toothman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108574/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 3:46 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Description
> -------
> 
> I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator).  I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized.  
> 
> 
> This addresses bug none.
>     http://bugs.kde.org/show_bug.cgi?id=none
> 
> 
> Diffs
> -----
> 
>   digikam/items/digikamimagedelegate.cpp 3e65a85 
>   digikam/items/imagedelegate.cpp 6dfad4f 
>   digikam/items/imagedelegatepriv.h 0ffa233 
>   digikam/main/digikamapp.cpp f9a1206 
>   digikam/utils/albumsettings.h 501213a 
>   digikam/utils/albumsettings.cpp b838479 
>   digikam/utils/tooltipfiller.h d384b82 
>   digikam/utils/tooltipfiller.cpp 57206cb 
>   libs/models/imagesortsettings.h 8db56e7 
>   libs/models/imagesortsettings.cpp cf01336 
>   libs/widgets/itemview/itemviewimagedelegate.h d1c3fd0 
>   libs/widgets/itemview/itemviewimagedelegate.cpp 1a1632c 
>   utilities/setup/setupalbumview.cpp f2d5e7c 
>   utilities/setup/setuptooltip.cpp b1ac814 
> 
> Diff: http://git.reviewboard.kde.org/r/108574/diff/
> 
> 
> Testing
> -------
> 
> I have tested the functionality and both work as expected.  I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.
> 
> 
> File Attachments
> ----------------
> 
> local diff I used for porting to the git code base
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/25/core_diff.txt
> 
> 
> Thanks,
> 
> Stephen Toothman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130129/dc3348a4/attachment.html>