<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108574/">http://git.reviewboard.kde.org/r/108574/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stephen,
I review your patch, apply it to current git/master implementation, and tested.
Where options are available in Setup to show aspect ratio properly on thumbnails view and tool-tips, i cannot see any option in Filters tab from Right side-bar to sort items by aspect ratio.
As you said in this entry description, this patch much add this feature... Or i forget something ?
http://www.flickr.com/photos/digikam/8425632063/sizes/o/in/photostream/
Note : if you use text Filter to sort items from icon view by aspect ratio, well where is the option in drop-down list available on the right of search text field ?
Another important point, the capability to find items by aspect ratio in Advanced Search dialog, through "Picture Properties" section. Here, again, no option are available. To be homogeneous, search by aspect ratio must be available too...
In all case, these entries from bugzilla must be closed when your patch will be ap^plied to git/master (after 3.0.0 release planed on 6 February):
https://bugs.kde.org/show_bug.cgi?id=121313
https://bugs.kde.org/show_bug.cgi?id=224549
Gilles Caulier
</pre>
<br />
<p>- Gilles</p>
<br />
<p>On January 28th, 2013, 3:46 p.m. UTC, Stephen Toothman wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Stephen Toothman.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2013, 3:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I turned on sorting by pixel size (width * height) and added sorting by aspect ratio (width and height divided by greatest common denominator). I use digikam to manage pictures and wallpapers I download and create, So these are two essential tools to help me stay organized. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested the functionality and both work as expected. I have used these patches since v2.5 and I am finally ready to share them as I think they are stable.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=none">none</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>digikam/items/digikamimagedelegate.cpp <span style="color: grey">(3e65a85)</span></li>
<li>digikam/items/imagedelegate.cpp <span style="color: grey">(6dfad4f)</span></li>
<li>digikam/items/imagedelegatepriv.h <span style="color: grey">(0ffa233)</span></li>
<li>digikam/main/digikamapp.cpp <span style="color: grey">(f9a1206)</span></li>
<li>digikam/utils/albumsettings.h <span style="color: grey">(501213a)</span></li>
<li>digikam/utils/albumsettings.cpp <span style="color: grey">(b838479)</span></li>
<li>digikam/utils/tooltipfiller.h <span style="color: grey">(d384b82)</span></li>
<li>digikam/utils/tooltipfiller.cpp <span style="color: grey">(57206cb)</span></li>
<li>libs/models/imagesortsettings.h <span style="color: grey">(8db56e7)</span></li>
<li>libs/models/imagesortsettings.cpp <span style="color: grey">(cf01336)</span></li>
<li>libs/widgets/itemview/itemviewimagedelegate.h <span style="color: grey">(d1c3fd0)</span></li>
<li>libs/widgets/itemview/itemviewimagedelegate.cpp <span style="color: grey">(1a1632c)</span></li>
<li>utilities/setup/setupalbumview.cpp <span style="color: grey">(f2d5e7c)</span></li>
<li>utilities/setup/setuptooltip.cpp <span style="color: grey">(b1ac814)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108574/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/25/core_diff.txt">local diff I used for porting to the git code base</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>