[Digikam-devel] Review Request 108382: Make tagging more accessible by keyboard

[Marcel Wiesweg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108382/#review31638
-----------------------------------------------------------


OK. Sorting is good, the "T" action sounds good.

Putting existing tags to the top and the creation of a new tag to the bottom is a decision based on personal preference. The current behavior favors creating new tags, while the patched behavior favors assigning existing tags by keyboard. Gilles, your opinion?

Some more questions:
- You remove  emit currentCompletionTextChanged(current->data...) Why? Unused, causing a bug?
- Why setCurrentRow(0)?

- Marcel Wiesweg


On April 21, 2013, 1:04 p.m., Markus Leuthold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108382/
> -----------------------------------------------------------
> 
> (Updated April 21, 2013, 1:04 p.m.)
> 
> 
> Review request for Digikam, Gilles Caulier and Marcel Wiesweg.
> 
> 
> Description
> -------
> 
> Make tagging more accessible by keyboard
> 
>  * Pressing "T" will focus the tagedit-box.
>  * The tag is applied by pressing enter. Pressing enter a second time will
>    focus the mainwindow and advance to the next image.
>  * The dropdown of the tagedit-box remembers already entered tags, the
>    order of the dropdown items are sorted such that already entered tags appear first.
>  * add tagging-by-keyboard to "Tips of the day"
> 
> 
> Diffs
> -----
> 
>   data/tips eef2262ef39fe77a65113f75be750122bda0f3fb 
>   digikam/main/digikamapp.cpp d7769e60d4181f95149774744fb93e711761c2ed 
>   digikam/main/digikamapp_p.h 2d9f0c20f65a29db153c868cbfcea2e5574b1bdd 
>   digikam/tags/addtagscompletionbox.cpp 266421c34fe6d939b094d0c0b1dea77065e024ee 
>   digikam/tags/addtagslineedit.h 1eec38c090eaefd592e4cc5c4561fadf04b9de26 
>   digikam/tags/addtagslineedit.cpp abcf5b1f9d9a0340a9838b267faa2637f989bd96 
>   digikam/views/digikamview.h 669eac958eeaa5aacb52f0a55d879175c4abbe34 
>   digikam/views/digikamview.cpp 89ae95684cef96da14df1807ab821f04d274471a 
>   libs/database/albumdb.cpp 8ca4fd0e0323fb7c8bae65f947d21b9d9ee6b50c 
>   libs/imageproperties/imagedescedittab.h 0dc7e31af05bf95a6caf5ee4edde962bda7c0e7a 
>   libs/imageproperties/imagedescedittab.cpp b6ce9494852b4a624addefa7c1fb1196ff265e68 
>   libs/imageproperties/imagepropertiessidebar.h f6703339fc2e1a5762f8db898e7ad69dddab7868 
> 
> Diff: http://git.reviewboard.kde.org/r/108382/diff/
> 
> 
> Testing
> -------
> 
> I successfully use this feature on a regular basis. Also tested with current HEAD, works fine.
> 
> 
> Thanks,
> 
> Markus Leuthold
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130426/8ccc527f/attachment.html>