[Digikam-devel] Review Request 108382: Make tagging more accessible by keyboard

[Gilles Caulier]

> On Jan. 13, 2013, 6:20 p.m., Marcel Wiesweg wrote:
> > The only changes I dont understand without explanation are those to AddTagsCompletionBox::setItems. What is achieved here?
> >
> 
> Markus Leuthold wrote:
>     Assume you have three tags "Albert", "Alice" and "Bertha" (parent tag is "People"). You want to assign "Alice" to your photo. With current digikam, you get the following situation after each keystroke:
>     
>     keystroke:items displayed
>     "A":"Create A in People", "Albert","Alice","Create A"  (Case A as labeled in sourcecode)
>     "l":"Create Al in People", "Albert","Alice","Create Al" (Case A)
>     "i":"Create Ali in People","Alice","Create Ali" (Case A)
>     "c":"Create Alic in People","Alice","Create Alic" (Case A)
>     "e":"Alice","Create Alice" (Case C)
>     
>     Please note that only after the fifth character, you can press enter to commit your tag. The first item is always selected, you can only press enter if your desired item is at position one. Now let's look at my patch, same scenario
>     
>     "A":"Albert","Alice","Create A in People","Create A" (Case A)
>     "l":"Albert","Alice","Create Al in People","Create Al" (Case A)
>     "i":"Alice","Create Ali in People","Create Ali" (Case A)
>     
>     After the 3rd character, you can press enter. Since I remember the chosen tags, "Alice" will be the first item for another photo (this logic is not in the setItems function, though). Assume you want to tag a second photo with "Alice"
>     
>     "A":"Alice" "Albert" "Create A in People" "Create A"
>     
>     Now you can already press enter after the first character, and you're done. With the current digikam version, you need to write the entire name.
>     
>     What I have to admit: I don't know how you can actually get into case B (no item selected at all). I checked with debug statements, and didn't figure out a way to hit that codepath, with current digikam as well as with my patch applied. But if this codepath is hit, the code should behave correctly.
>     
>     Does it become more clear to you what my modifications in setItems do?
>     
>     
>     
>     
>

Marcel,

What's about this entry. Previous explanation is fine for you ?

Did you test the patch to check feature ?

Gilles


- Gilles


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108382/#review25393
-----------------------------------------------------------


On April 21, 2013, 1:04 p.m., Markus Leuthold wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108382/
> -----------------------------------------------------------
> 
> (Updated April 21, 2013, 1:04 p.m.)
> 
> 
> Review request for Digikam, Gilles Caulier and Marcel Wiesweg.
> 
> 
> Description
> -------
> 
> Make tagging more accessible by keyboard
> 
>  * Pressing "T" will focus the tagedit-box.
>  * The tag is applied by pressing enter. Pressing enter a second time will
>    focus the mainwindow and advance to the next image.
>  * The dropdown of the tagedit-box remembers already entered tags, the
>    order of the dropdown items are sorted such that already entered tags appear first.
>  * add tagging-by-keyboard to "Tips of the day"
> 
> 
> Diffs
> -----
> 
>   data/tips eef2262ef39fe77a65113f75be750122bda0f3fb 
>   digikam/main/digikamapp.cpp d7769e60d4181f95149774744fb93e711761c2ed 
>   digikam/main/digikamapp_p.h 2d9f0c20f65a29db153c868cbfcea2e5574b1bdd 
>   digikam/tags/addtagscompletionbox.cpp 266421c34fe6d939b094d0c0b1dea77065e024ee 
>   digikam/tags/addtagslineedit.h 1eec38c090eaefd592e4cc5c4561fadf04b9de26 
>   digikam/tags/addtagslineedit.cpp abcf5b1f9d9a0340a9838b267faa2637f989bd96 
>   digikam/views/digikamview.h 669eac958eeaa5aacb52f0a55d879175c4abbe34 
>   digikam/views/digikamview.cpp 89ae95684cef96da14df1807ab821f04d274471a 
>   libs/database/albumdb.cpp 8ca4fd0e0323fb7c8bae65f947d21b9d9ee6b50c 
>   libs/imageproperties/imagedescedittab.h 0dc7e31af05bf95a6caf5ee4edde962bda7c0e7a 
>   libs/imageproperties/imagedescedittab.cpp b6ce9494852b4a624addefa7c1fb1196ff265e68 
>   libs/imageproperties/imagepropertiessidebar.h f6703339fc2e1a5762f8db898e7ad69dddab7868 
> 
> Diff: http://git.reviewboard.kde.org/r/108382/diff/
> 
> 
> Testing
> -------
> 
> I successfully use this feature on a regular basis. Also tested with current HEAD, works fine.
> 
> 
> Thanks,
> 
> Markus Leuthold
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130421/2351aa9c/attachment.html>