[Digikam-devel] regarding my assigned bug

[Markus Leuthold]

Hello Saurabh

The patch works fine with current HEAD from today (after rebasing), I just 
tested it. Pressing T focusses the editbox, the sorting works as intended with 
the patch. You probably forgot to rebase?

I've added a "tip of the day" to make the feature visible to the user.

best, Markus



On Tuesday 09 April 2013 02.14:37 Saurabh Patel wrote:

Hello,

   As Gilles pointed out in his previous reply,this patch needs to be tested 
on digikam 3 where a tableview branch would be merged.


So I tested this patch on digikam 3.2.0 beta.This patch didn't work at all.


First pressing T doesn't open Tags section from rightsidebar.


Then autocompletion of tags as suggested by Markus doesn't work.It remains 
same for digikam after applying patch the code.

Eg:Say I added tag 'abcde' and then tag 'abcdef' so according to patch 
'abcdef' should be seen above 'abcde' in autocompletion since it is more 
recent but 'abcde' appears first in autocompletion than 'abcdef'


I had tested this on digikam 2 where this patch worked as Markus thought but 
now in digikam 3.2.0 beta it doesn't work


So kindly look into it



Thanks




On Tue, Apr 2, 2013 at 8:02 PM, Saurabh Patel <saurabhpatel7717 at gmail.com> 
wrote:

Hello,

    I recently got digikam 3.2.0 beta installed and saw that a sort of tool 
tip similar to tip required by this patch is already there with only difference 
that instead of pressing enter twice it requires pressing enter and then page 
down to assign tag to the image so it's just change of shortcut key.Also auto-
completion feature based on alphabetical and most recently added tags is 
implemented as done by this patch so what further is to be done with this bug 
or should it be closed.


When I was assigned this bug it was already implemented and had only to be 
tested which I have tested.


Thanks




On Tue, Mar 12, 2013 at 10:48 AM, Saurabh Patel <saurabhpatel7717 at gmail.com> 
wrote:

Hello,
     I tried to add tip of day for my assigned tag in digikam-software-
compilation/core/data/Tips.html then I build digikam again using 
bootstrap.local,make,make install and tried to see if tip I added was visible 
in tip of day after running digikam but I was not able to see the tip I added.
Plz tell whether I am testing it correctly or not and also let me know if that 
tip is to be added somewhere also which might be problem.

Thanks

On Mon, Mar 11, 2013 at 11:46 AM, Gilles Caulier <caulier.gilles at gmail.com> 
wrote:






2013/3/6 Saurabh Patel <saurabhpatel7717 at gmail.com>

Hello,
    Regarding shortcut menu being made visible to the user,Tip of the day 
would be a good idea rather than status bar because tip of the day are meant 
for providing tips which can make our work easy but not necessary to apply.



You can patch tips of day content of course...


 
    Regarding moving to next image after pressing enter twice,it seems difficult 
to be made obvious.Maybe along with the tip for the shortcut we could append 
this feature in tip.



patch need to be tested on my computer.
 
    Thnx for clarifying regarding sorting.
    Also is there anything which has to be done to this patch other than 
testing.




3.1.0 release will be done soon. After that, a tableview branch will be merged 
to git/master. Patch much be adapted to this branch to compile fine. 


Gilles Caulier


_______________________________________________
Digikam-devel mailing list
Digikam-devel at kde.org
https://mail.kde.org/mailman/listinfo/digikam-devel










-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130421/2aa9ed89/attachment.html>