[Digikam-devel] query regarding a TODO

Saurabh Patel saurabhpatel7717 at gmail.com
Tue Apr 2 15:41:02 BST 2013


Hello,
   It's been long time I forwarded mail to Jens Mueller.Any help on this or
a way to contact him
Thanks


On Tue, Mar 12, 2013 at 7:01 AM, Saurabh Patel
<saurabhpatel7717 at gmail.com>wrote:

> Hello,
>      Thanks Markus,I got his email address from identity.kde.org and am
> sending this mail to him now.
>
> Thanks again
>
>
> On Tue, Mar 12, 2013 at 1:36 AM, Michael G. Hansen <mike at mghansen.de>wrote:
>
>> Hi,
>>
>>
>> On 03/11/2013 08:46 PM, Saurabh Patel wrote:
>>
>>> Hello,
>>>
>>>      Thanks for Michael.I was able to find who wrote that line of
>>> code.His
>>> name is Jens Mueller so how can I get in contact with him.Also Gilles
>>> told
>>> that wait would be better option but it's a long time since we discussed
>>> this todo and no-one has yet replied.So what should be done now and how
>>> to
>>> know way to contact Jens Mueller.
>>>
>>
>> You can go to identity.kde.org and sign in there (you should be able to
>> if you have a kde account). Under the people tag, you can search for his
>> name and find his e-mail address if he is still registered.
>>
>> Another way is to search the digikam source code for his name, as most
>> people left their name and e-mail address in the header lines of the files
>> they worked on.
>>
>>
>>  PS: I know this is a minor patch but this would at least remove a todo
>>> from
>>> project
>>>
>>
>> It is also a good way to get started ;-)
>>
>> Best regards,
>>
>> Michael
>>
>>
>>> Thanks
>>>
>>> On Tue, Mar 12, 2013 at 1:02 AM, Michael G. Hansen <mike at mghansen.de>
>>> wrote:
>>>
>>>  Hi,
>>>>
>>>>
>>>> On 03/04/2013 01:35 PM, Saurabh Patel wrote:
>>>>
>>>>  Hello,
>>>>>       So what should be done.TODO should be removed or wait for the
>>>>> reply
>>>>> of
>>>>> one who coded
>>>>>
>>>>>
>>>> you can find out who wrote the code using git`s blame command:
>>>>
>>>> git blame filename
>>>>
>>>> This will give you the names of the people who wrote each line. If you
>>>> are
>>>> using an IDE such as kdevelop, it can also show this information. The
>>>> feature is called "annotate" there.
>>>>
>>>> Best regards,
>>>>
>>>> Michael
>>>>
>>>>
>>>>  Thanks
>>>>>
>>>>> On Mon, Mar 4, 2013 at 5:45 PM, Gilles Caulier <
>>>>> caulier.gilles at gmail.com>
>>>>> **wrote:
>>>>>
>>>>>
>>>>>   I think *m_talker->loggedIn() is a method to check if talker is
>>>>> already
>>>>>
>>>>>> logged (as it return bool).*
>>>>>> *
>>>>>> *
>>>>>> *I don't coded this tool, so i'm not sure...*
>>>>>> *
>>>>>> *
>>>>>> *As well, for me, code commented can be removed...*
>>>>>> *
>>>>>> *
>>>>>> *Gilles Caulier*
>>>>>>
>>>>>>
>>>>>> 2013/3/4 Saurabh Patel <saurabhpatel7717 at gmail.com>
>>>>>>
>>>>>>   Hello,
>>>>>>
>>>>>>>       I was going through kipi-plugins in digikam.In kipi-plugin for
>>>>>>> picasawebexport I found a TODO on line 320 in picasawebwindow.cpp.I
>>>>>>> am
>>>>>>> pasting the whole method here.
>>>>>>>
>>>>>>> void PicasawebWindow::****slotLoginDone(int errCode, const QString&
>>>>>>> errMsg)
>>>>>>> {
>>>>>>>       m_widget->progressBar()->hide(****);
>>>>>>>
>>>>>>>
>>>>>>>      * if (errCode == 0 /*TODO&& m_talker->loggedIn()*/)*
>>>>>>>
>>>>>>>       {
>>>>>>>           buttonStateChange(true);
>>>>>>>           m_token = m_talker->token();
>>>>>>>           m_widget->m_albumsCoB->clear()****;
>>>>>>>           m_talker->listAlbums(m_talker-****>getUserName());
>>>>>>>
>>>>>>>       }
>>>>>>>       else
>>>>>>>       {
>>>>>>>           KMessageBox::error(this, i18n("Picasaweb Call Failed:
>>>>>>> %1\n",
>>>>>>> errMsg));
>>>>>>>       }
>>>>>>> }
>>>>>>>
>>>>>>>
>>>>>>> I have a question that the method loggedIn is not defined in
>>>>>>> picasawebtalker so is it to be implemented there.Also is it necessary
>>>>>>> since
>>>>>>> signallogindone signal in picasawebtalker is emitted after checking
>>>>>>> success
>>>>>>> to get username and password
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> ______________________________****_________________
>>>>>>> Digikam-devel mailing list
>>>>>>> Digikam-devel at kde.org
>>>>>>> https://mail.kde.org/mailman/****listinfo/digikam-devel<https://mail.kde.org/mailman/**listinfo/digikam-devel>
>>>>>>> <https:**//mail.kde.org/mailman/**listinfo/digikam-devel<https://mail.kde.org/mailman/listinfo/digikam-devel>
>>>>>>> >
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>  ______________________________****_________________
>>>>>> Digikam-devel mailing list
>>>>>> Digikam-devel at kde.org
>>>>>> https://mail.kde.org/mailman/****listinfo/digikam-devel<https://mail.kde.org/mailman/**listinfo/digikam-devel>
>>>>>> <https:**//mail.kde.org/mailman/**listinfo/digikam-devel<https://mail.kde.org/mailman/listinfo/digikam-devel>
>>>>>> >
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>> ______________________________****_________________
>>>>> Digikam-devel mailing list
>>>>> Digikam-devel at kde.org
>>>>> https://mail.kde.org/mailman/****listinfo/digikam-devel<https://mail.kde.org/mailman/**listinfo/digikam-devel>
>>>>> <https:**//mail.kde.org/mailman/**listinfo/digikam-devel<https://mail.kde.org/mailman/listinfo/digikam-devel>
>>>>> >
>>>>>
>>>>>
>>>>>  ______________________________****_________________
>>>> Digikam-devel mailing list
>>>> Digikam-devel at kde.org
>>>> https://mail.kde.org/mailman/****listinfo/digikam-devel<https://mail.kde.org/mailman/**listinfo/digikam-devel>
>>>> <https:**//mail.kde.org/mailman/**listinfo/digikam-devel<https://mail.kde.org/mailman/listinfo/digikam-devel>
>>>> >
>>>>
>>>>
>>>
>>>
>>> ______________________________**_________________
>>> Digikam-devel mailing list
>>> Digikam-devel at kde.org
>>> https://mail.kde.org/mailman/**listinfo/digikam-devel<https://mail.kde.org/mailman/listinfo/digikam-devel>
>>>
>>>
>> ______________________________**_________________
>> Digikam-devel mailing list
>> Digikam-devel at kde.org
>> https://mail.kde.org/mailman/**listinfo/digikam-devel<https://mail.kde.org/mailman/listinfo/digikam-devel>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20130402/040731d4/attachment.html>


More information about the Digikam-devel mailing list