[Digikam-devel] [digikam] /: On Linux, use Inotify directly for file notification changes

[Gilles Caulier]

Thanks Marcel for the info ,

Ananta Palani who work under Windows to port digiKam. He build installer
and can help us around this subject...

Best

Gilles Caulier

2011/11/8 Marcel Wiesweg <marcel.wiesweg at gmx.de>:
>
>
>> Marcel,
>>
>> very interesting solution. I'm sure that some bugzilla files will be
>> closed in the future.
>>
>> KInotify do not exist in KDELibs yet ? Or do you have customized this
>> implementation for digiKam ?
>
> It's not yet in kdelibs, it was only recently written for use inside the
Nepomuk indexer. The code was copied and slightly customized from Nepomuk
Core.
> In the current form, I'm not sure it will ever be in kdelibs: For Linux,
it's the best solution, because we get information in better quality, and
we get the information which we really need (closed-after-write). But
Inotify is definitely Linux-only.
> If there are comparable solutions for Windows and Mac, the way to go
would be to extend KDirWatch API and offer this cross-platform. But I dont
know about available APIs on these systems.
>
> Marcel
> --
> NEU: FreePhone - 0ct/min Handyspartarif mit Geld-zurück-Garantie!
> Jetzt informieren: http://www.gmx.net/de/go/freephone
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel
>
>
--------------------------------------------------------------------------------------------------------------

Marcel,

very interesting solution. I'm sure that some bugzilla files will be
closed in the future.

KInotify do not exist in KDELibs yet ? Or do you have customized this
implementation for digiKam ?

Best

Gilles

>
--------------------------------------------------------------------------------------------------------------

Git commit dcf2ba9d7e92d51b049bdd354f82ddbf75e51a31 by Marcel Wiesweg.
Committed on 07/11/2011 at 22:47.
Pushed by mwiesweg into branch 'master'.

On Linux, use Inotify directly for file notification changes

Use Sebastian Trueg's KInotify wrapper, if Inotify is available.
This gives much more detailed reports and especially info when a file
has been closed after write. For a detailed explanation, see
http://trueg.wordpress.com/2011/10/13/taking-a-break-from-crash-fixing-for-usability/
Separate the file watch code from AlbumManager to a new class, AlbumWatch.
Do not watch directories recursively (convenient API, but often inefficient
implementation
out of our reach). We scan the directories anyway, it is possible and
efficient to
add each directory = album separately.
If Inotify is not available (non-linux), the previous code based on
KDirWatch and KIO is still used.

CCMAIL: digikam-devel at kde.org

M  +5    -2    CMakeLists.txt
M  +1    -1    digikam/CMakeLists.txt
M  +7    -209  digikam/album/albummanager.cpp
M  +0    -5    digikam/album/albummanager.h
A  +512  -0    digikam/album/albumwatch.cpp     [License: GPL (v2+)]
A  +90   -0    digikam/album/albumwatch.h     [License: GPL (v2+)]
A  +517  -0    libs/3rdparty/kinotify/kinotify.cpp     [License: LGPL (v2+)]
A  +198  -0    libs/3rdparty/kinotify/kinotify.h     [License: LGPL (v2+)]

http://commits.kde.org/digikam/dcf2ba9d7e92d51b049bdd354f82ddbf75e51a31
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20111108/4c16b915/attachment.html>