[Digikam-devel] Re: Color theme plan...

[Andi Clemens]

I guess this sounds fine, we definitely need to fix theming issues, either  
by removing it completely (not so good) or by adapting to the KDE theming  
(good :-) ).

Andi

On Wed, 06 Apr 2011 16:21:05 +0200, Gilles Caulier  
<caulier.gilles at gmail.com> wrote:

> Hi all,
>
> I plan to make severals changes in Theme Manager in a near future. My
> plan is to remove all customized XML theme and to use KDE color theme
> instead, as KDenlive do...
>
> http://www.flickr.com/photos/digikam/5595401580/sizes/o/in/photostream/
>
> The goal is to fix all mistakes with colors melange reported in
> bugzilla. Also, this will simplify theme management :
>
> - there is a complex color assignment in this method :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/themeengine/themeengine.cpp#L302
>
> This code have been back-ported from Amarok 1.4 by me in the pass.
> Sound like not all colors mix are perfect in GUI.
>
> - there are a lots of KDE color theme schemes down-loadable by KDE
> control panel.
>
> Only ThemeEngine class will be touch by this change. 2 others classes
> still unchanged. In Theme, we populate all KDE color themes available
> and we assign it to digiKam when user select one of them in theme menu
> entry. XML interface will be removed, but all the rest of color
> assignment still there, especially this method :
>
> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/themeengine/themeengine.cpp#L302
>
> In fact, we assign palette from KDE theme to digiKam and we build
> theme by this method. In changePalette() method we just assign the
> palette and no more...
>
> Gilles Caulier
> _______________________________________________
> Digikam-devel mailing list
> Digikam-devel at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-devel


-- 
Using Opera's revolutionary email client: http://www.opera.com/mail/