[Digikam-devel] Review Request: Fix libkmap build after kdeedu shift to git

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101036/
-----------------------------------------------------------

Review request for Digikam.


Summary
-------

libkmap doesn't seem to build in Git for me due to not having Marble installed (i.e. the find_package(MarbleWidget) line).

Marble installs a FindMarble.cmake, not FindMarbleWidget.cmake (which was installed with kdeedu before the kdeedu switch to git). Altering the variable names used to match what is exported by Marble's FindMarble.cmake allows libkmap to build.

I'm making a review request instead of simply committing the build fix just to ensure that if you guys are trying to maintain compatibility with much older versions of KDE libs/Marble/etc that I don't mess it up for you. It looks like Marble has installed FindMarble.cmake for some time so it seems safe to me, but I haven't extensively looked into that.


Diffs
-----

  CMakeLists.txt 8e3965f 
  libkmap/CMakeLists.txt 87b8c7f 

Diff: http://git.reviewboard.kde.org/r/101036/diff


Testing
-------

libkmap builds and installs properly.
Digikam now gets to the point of detecting libkmap before failing due to libkface (?) not being installed. :(
 - libkface seems to require something called OpenCV. Perhaps tomorrow I'll have Digikam. :)


Thanks,

Michael

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20110406/ea59d02a/attachment.html>