<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101036/">http://git.reviewboard.kde.org/r/101036/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Digikam.</div>
<div>By Michael Pyne.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">libkmap doesn't seem to build in Git for me due to not having Marble installed (i.e. the find_package(MarbleWidget) line).
Marble installs a FindMarble.cmake, not FindMarbleWidget.cmake (which was installed with kdeedu before the kdeedu switch to git). Altering the variable names used to match what is exported by Marble's FindMarble.cmake allows libkmap to build.
I'm making a review request instead of simply committing the build fix just to ensure that if you guys are trying to maintain compatibility with much older versions of KDE libs/Marble/etc that I don't mess it up for you. It looks like Marble has installed FindMarble.cmake for some time so it seems safe to me, but I haven't extensively looked into that.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">libkmap builds and installs properly.
Digikam now gets to the point of detecting libkmap before failing due to libkface (?) not being installed. :(
- libkface seems to require something called OpenCV. Perhaps tomorrow I'll have Digikam. :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8e3965f)</span></li>
<li>libkmap/CMakeLists.txt <span style="color: grey">(87b8c7f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101036/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>