[Digikam-devel] [Bug 148540] Improvements of adding noise tool
Gilles Caulier
caulier.gilles at gmail.com
Thu Mar 18 13:18:59 GMT 2010
https://bugs.kde.org/show_bug.cgi?id=148540
--- Comment #39 from Gilles Caulier <caulier gilles gmail com> 2010-03-18 14:18:51 ---
Created an attachment (id=41733)
--> (http://bugs.kde.org/attachment.cgi?id=41733)
First approach of Chrominance noise implementation
Julien,
Please, take a look in my patch. It use 2 new methods from DColor class to
convert RGB <-> YCbCr color space.
Currently chrominance blue and red are adjusted at the same time. I think it
will be better to add Blue and Red noise independently.
Also, in GUI, the user must be able to enable/disable noise type adjustement.
Typically, user must be able to apply only luminance noise, or/and Chrominance
Blue noise, or/and Chrominance Red noise. Using Checkbox there is the solution.
Of course filter need new settings for that.
The result are not very nice about Chrominance (over-saturated). Something is
wrong somewhere, perhaps in DColor::getYCbCr(), DColor::setYCbCr(), or in
filter as well. I don't know yet. Investigations are require.
Anyway, this is the right way to go about Chrominance noise.
Gilles Caulier
--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the Digikam-devel
mailing list