[Digikam-devel] [Bug 149485] Advanced image resize for the digikam editor

Julien Narboux Julien at narboux.fr
Thu Jun 4 17:47:41 BST 2009


https://bugs.kde.org/show_bug.cgi?id=149485





--- Comment #208 from Julien Narboux <Julien narboux fr>  2009-06-04 18:47:30 ---
Carlo, 

We have small problem, the current implementation is not thread safe and we
will need a thread safe implementation in the future when lqr resizing is used
inside the batch queue manager. The reason it is not thread safe is the
presence of static functions for the progress bar. 
http://lxr.kde.org/source/extragear/graphics/digikam/imageplugins/contentawareresizing/contentawareresizer.cpp#42
http://lxr.kde.org/source/extragear/graphics/digikam/imageplugins/contentawareresizing/contentawareresizer.cpp#47

Gilles told me that the solution is to put the static method in the private
class: ContentAwareResizerPriv
This can not be done right now because Lqr use C style to access those
functions.

The solution is to add another argument of type void* to send the address of
the private class and then do a static cast.
In the Gimp Lqr plugin this void* would be NULL as you do not need it becasue
it is pure C.

You can see how Gilles solved the same problem for another C library here:
http://websvn.kde.org/?view=rev&revision=977483

Julien

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the Digikam-devel mailing list