[Digikam-devel] SpliiterState

Andi Clemens andi.clemens at gmx.net
Tue Dec 2 11:24:05 GMT 2008


On Tuesday 02 December 2008 12:17:07 Gilles Caulier wrote:
> Andi,
>
> Undependetly of spliter size bug, i cannot find an fine explication why the
> image is not displayed in case of splitter size is null (thumbbar not
> visible).
>
> This is not logic to not show preview image here. I suspect that zoom level
> (from status bar) has an invalid value at first init. later, it is relevant
> of preview widget size to be initialized properly (when splitter is
> resized).
>
> To resume my idea, i suspect a race condition between zoom level and
> preview widget/Splitter/thumbbar are displayed (initialized).
>
> Can you feel my viewpoint ?

I can "feel" you ... ;-)

This is what I was silently thinking, too. It doesn't make sense that you 
can't see the preview, only because the splitter is minimzed.
So it might be a size problem of the preview image.

And what about the empty folders / albums / tags when importing KDE3 database?

Marcel,
any idea?

Andi

>
> Gilles
>
> 2008/12/2 Andi Clemens <andi.clemens at gmx.net>
>
> > Bad news :-(
> > This patch doesn't help, and some of our old bugs are still available,
> > too.
> >
> > I copied my KDE3 rc file into the KDE4 folder and let digikam convert the
> > database and the rc file (with and without this patch).
> >
> > After the conversion was finished, I could see my tags and albums, but no
> > thumbnails (kioslave is working of course). Switching between tags, date
> > and
> > album view doesn't help. Also scanning for new images is not bringing
> > back the thumbnails. I had to restart.
> >
> > After that, thumbnails are visible, BUT: Clicking on them will not
> > display anything. I have to resize the splitter again to see anything.
> > I would say something goes wrong here while converting, would make sense,
> > but
> > why can't I see thumbnails on first start?
> >
> > I have turned on the displaying of the total numbers of images in a
> > folder, every folder has a (0) label beside itself. This means that the
> > images are not recognized at all, it is not just a displaying problem.
> >
> > So actually two of our most annoying bugs are still present: No images on
> > first start (after conversion) and the splitter bug (DAMN YOU SPLITTER
> > :-))
> >
> > Andi
> >
> > On Monday 01 December 2008 21:41:44 Andi Clemens wrote:
> > > Somehow I'm not sure if it really fixes the splitter problems... I had
> >
> > the
> >
> > > issue just 2 minutes ago... AGAIN!
> > > Now I don't know if I had messed up my digikamrc file or if it is the
> >
> > same
> >
> > > old bug we are hunting for moths now.
> > >
> > > I will not commit it and test it a little more. Next I will convert
> > > from KDE3 to KDE4, it should fail then...
> > > I will keep you informed.
> > >
> > > Andi
> > >
> > > On Monday 01 December 2008 21:21:50 Andi Clemens wrote:
> > > > On Monday 01 December 2008 21:13:38 Marcel Wiesweg wrote:
> > > > > > Marcel, any comment on why we use toBase64() methods to save
> >
> > splitter
> >
> > > > > > state? Otherwise I will commit the changes to SVN, for me it
> > > > > > works fine in my GIT repo, even with "broken" digikamrc files.
> > > > > >
> > > > > > Andi
> > > > >
> > > > > We get raw binary data from QSplitter, and use toBase64 to encode
> > > > > it
> >
> > to
> >
> > > > > ASCII to store it in the config file. We use toBase64 before we
> > > > > store to KConfig and use fromBase64 after reading from KConfig.
> > > > > I dont know any more where we took that from or if I made this up
> > > > > myself, and I dont know if this is strictly necessary. Possibly
> >
> > KConfig
> >
> > > > > can perfectly well store raw binary data.
> > > > > If you can confirm that bugs are caused by this and after removal
> > > > > the problems are solved, and configuration is always saved, then
> > > > > please commit. (Keep in mind that when you remove fromBase64 the
> > > > > "broken" digikamrc files will fail to load at all.)
> > > >
> > > > No, they load perfectly... I assume that the SplitterState config
> > > > vars will not be read at all (because they are unknown now) and the
> > > > default values will be used. After closing digiKam, the new
> > > > SplitterState will
> >
> > be
> >
> > > > saved.
> > > >
> > > > OK I will commit it then...
> > > >
> > > > Andi
> > > >
> > > > > Marcel
> > > > > _______________________________________________
> > > > > Digikam-devel mailing list
> > > > > Digikam-devel at kde.org
> > > > > https://mail.kde.org/mailman/listinfo/digikam-devel
> > > >
> > > > _______________________________________________
> > > > Digikam-devel mailing list
> > > > Digikam-devel at kde.org
> > > > https://mail.kde.org/mailman/listinfo/digikam-devel
> > >
> > > _______________________________________________
> > > Digikam-devel mailing list
> > > Digikam-devel at kde.org
> > > https://mail.kde.org/mailman/listinfo/digikam-devel
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > Digikam-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/digikam-devel




More information about the Digikam-devel mailing list