[Digikam-devel] [Bug 103350] its too easy to save images

Jens B.Benecke jens-bugs.kde.org at spamfreemail.de
Tue Oct 24 12:44:19 BST 2006


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=103350         




------- Additional Comments From jens-bugs.kde.org spamfreemail de  2006-10-24 13:44 -------
Embedding Subversion (a hugely complex system) transparently into an application is a huge effort.

Calling external processes opens up a lot of security problems (escaping file names with special characters? How about UTF-8? what if the external process crashes and/or leaves temp files laying around? what if the user has defined aliases? what if he has subversion installed in a different path? etc). If anything, the library functions must be used. Plus, you don't solve dependancies by not calling the libraries - they are also needed by the external binaries you call.

SQLite solves this problem elegantly by consisting only of two files - the SQLite library, and the database file (or files) you create, one per database. This is peanuts to embed. I'm guessing SVN is a whole new beast.

Plus, if we do that we must really forbid the user to muck about in the Images directory himself, because otherwise Subversion will choke if there were external changes, or diffs are missing, or whatever.


I agree that Subversion is a great system, but IMHO it's total overkill for Digikam.

OTOH, we can just require Reiser4 file system with the versioning plugin, and all problems would be solved. ;-)



More information about the Digikam-devel mailing list