[Digikam-devel] [PATCH] use a QListBox rather than a set of radio buttons for b&w plugin, take 2

Caulier Gilles caulier.gilles at kdemail.net
Tue May 9 00:40:08 BST 2006


Le Mardi 09 Mai 2006 12:27 AM, Guillaume Laurent a écrit :
> On Tuesday 02 May 2006 00:02, Guillaume Laurent wrote:
> > Another improvement would be to display several filter results at the
> > same time so you can more easily compare between them, rather than just
> > seeing one effect at a time.
>
> Since the QListBox can do that, I gave it a try. Here's a modified version
> of my previous patch which displays a thumbnail of the applied effect. See
> attached screenshot for a better idea.
>

Accepted. In this case, the QListBox have a sence for me.

It's possible to have the same preview into Color Autocorrection tool ? 
(:=)))...

> BTW, if I may make a code style comment, the following construct :
>
> if (foo)
>     delete foo;
>
> is not necessary, 'delete 0' is a no-op, so just 'delete foo' will work
> just as well.

Yes, this is the story of an old code (:=)))...

Gilles



More information about the Digikam-devel mailing list