[Digikam-devel] [PATCH] use a QListBox rather than a set of radio buttons for b&w plugin, take 2

Guillaume Laurent glaurent at telegraph-road.org
Mon May 8 23:27:25 BST 2006


On Tuesday 02 May 2006 00:02, Guillaume Laurent wrote:
>
> Another improvement would be to display several filter results at the same
> time so you can more easily compare between them, rather than just seeing
> one effect at a time.

Since the QListBox can do that, I gave it a try. Here's a modified version of 
my previous patch which displays a thumbnail of the applied effect. See 
attached screenshot for a better idea.

BTW, if I may make a code style comment, the following construct :

if (foo)
    delete foo;

is not necessary, 'delete 0' is a no-op, so just 'delete foo' will work just 
as well.

-- 
Guillaume.
http://www.telegraph-road.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bwplugin.jpg
Type: image/jpeg
Size: 458870 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20060509/13971b98/attachment.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bwplugin_listbox_take2.patch
Type: text/x-diff
Size: 12402 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20060509/13971b98/attachment.patch>


More information about the Digikam-devel mailing list