[Digikam-devel] [Bug 130798] digikam editor saves some jpeg's 30% smaller than original - even with jpeg compression option set at 100

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=130798         
caulier.gilles free fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles free fr  2006-07-16 09:21 -------
SVN commit 562897 by cgilles:

digiKam from trunk: fix libjpeg quality value used to save a new file if setup jpeg compression ratio is 100.
BUG: 130798


 M  +5 -2      NEWS  
 M  +0 -2      TODO  
 M  +2 -2      utilities/imageeditor/editor/editorwindow.cpp  


--- trunk/extragear/graphics/digikam/NEWS #562896:562897
 @ -131,7 +131,8  @
 068 ==> 121367 : Add properties tab to digiKam and (especially) Image Editor.
 069 ==> 125926 : Directories with a '#' in their name are not properly detected when created outside digikam.
 070 ==> 125733 : Enabling 'Always apply ICM profiles' can lead to suprising results.
-071 ==> 126326 : camera download: auto-rotated images loose EXIF info when 'No EXIF information found.' is written to console.
+071 ==> 126326 : camera download: auto-rotated images loose EXIF info when 'No EXIF information found.' 
+                 is written to console.
 072 ==> 121242 : mimelnk/x-image-raw.desktop conflicts with kdegraphics-3.5.x.
 073 ==> 127374 : unsharp mask: max. radius way too small.
 074 ==> 116485 : Mimimize button missing on "Compaq Flash Reader" camera window.
 @ -167,6 +168,8  @
 104 ==> 130381 : Automatic colorbalance and camera color balance checkboxes swapped.
 105 ==> 117248 : Opening default app when camera inserted return KIOExec error.
 106 ==> 130883 : Overexposure indicator in color management is saved as part of the picture
-107 ==> 
+107 ==> 130798 : Editor saves some jpeg's 30% smaller than original,
+                 even with jpeg compression option set at 100.
+108 ==> 
 
 ----------------------------------------------------------------------------------------------------
--- trunk/extragear/graphics/digikam/TODO #562896:562897
 @ -34,8 +34,6  @
 ==> 111446 : Image Editor   : bad behaviour when out of disk space
 ==> 128104 : Image Editor   : digiKam Crash when browsing photos in Image Editor
 ==> 130525 : Image Editor   : Saving large (>5M) jpg's result in corrupt file
-==> 130798 : Image Editor   : Editor saves some jpeg's 30% smaller than original,
-                              even with jpeg compression option set at 100.
 
 ==> 127583 : Main interface : keywords, copyright, photographer info not saved to IPTC
 ==> 127179 : Main interface : thumbnails does not adhere to the Rotate Images setting in Configure digiKam
--- trunk/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp #562896:562897
 @ -724,8 +724,8  @
     config->setGroup("ImageViewer Settings");
 
     // JPEG quality slider settings : 0 - 100 ==> libjpeg settings : 25 - 100.
-    m_IOFileSettings->JPEGCompression  = (int)((75.0/99.0)*(float)config->readNumEntry("JPEGCompression", 75)
-                                               + 25.0 - (75.0/99.0));
+    m_IOFileSettings->JPEGCompression  = (int)((75.0/100.0)*(float)config->readNumEntry("JPEGCompression", 75)
+                                               + 26.0 - (75.0/100.0));
 
     // PNG compression slider settings : 1 - 9 ==> libpng settings : 100 - 1.
     m_IOFileSettings->PNGCompression   = (int)(((1.0-100.0)/8.0)*(float)config->readNumEntry("PNGCompression", 1)