[Digikam-devel] New iconset integration for DigiKam 0.8.1 and 0.9.0

[Tung NGUYEN]

Le Mercredi 11 Janvier 2006 00:42, Achim Bohnet a écrit :

> Mhmm, make it's just the first time I noticed this:
>
> a) make -f Makefile.cvs
> ...
> unknown icon type  in digikam/digikam/pics/Makefile.in (tag.png)
> unknown icon type histogram in digikam/digikam/pics/Makefile.in
> (histogram-lin.png) unknown icon type histogram in
> digikam/digikam/pics/Makefile.in (histogram-log.png) unknown icon type
> image in digikam/digikam/pics/Makefile.in (image-full.png) unknown icon
> type image in digikam/digikam/pics/Makefile.in (image-selection.png)
> unknown icon type  in digikam/digikam/pics/Makefile.in (image_broken.png)
> unknown icon type  in digikam/digikam/pics/Makefile.in (rating.png) unknown
> icon prefix tag in digikam/digikam/pics/Makefile.in
> unknown icon prefix tag in digikam/digikam/pics/Makefile.in
> unknown icon prefix tag in digikam/digikam/pics/Makefile.in
> unknown icon prefix tag in digikam/digikam/pics/Makefile.in
> unknown icon type showfoto in digikam/showfoto/pics/Makefile.in
> (showfoto-splash.png) ...
>

"unknown ..." 1 to 11 appear in Konsole because of the 2 lines I added to  
digikam/digikam/pics/Makefile.am :

digikamicondir = $(kde_datadir)/digikam/icons
digikamicon_ICON = AUTO

to process automatically all the icons relating to hicolor or crystalsvg 
theme. "make -f Makefile.cvs" displays such messages for all the PNGs which 
have a wrong name.

Notice that the last message "unknown icon type showfoto in..." already exists 
before the integration of the new iconset. The same problem applies to 
ShowFoto.

> 1) can't we simple rename tags(whatever).png to
> hi32-action-tags<whatever>.png 
>

Not necessarily, because tags(whatever).png are "private" icons (no need to 
use them in different sizes).

> 2) Stupid non programer question: why are 
> the image* histogram* and ratin* icons installed into apps/digikam/data/ 
> and not below the apps/digikam/icons tree as actions [+ a rename in as in
> 1)]
>

Perhaps, it's a choice to consider them as "private" icons (like 
tags(whatever).png, no need to use them in different sizes) and to put them 
in apps/digikam/data/.

> b) some icons have the 'x' bit set.  I will remove it.
>

Thank you. :-)

> c) In digikam/digikam/pics are also
>
> -rw-r--r-- 1 ach ach 19430 2006-01-06 20:25 cr128-action-fileopen.png
> -rw-r--r-- 1 ach ach  1065 2006-01-06 20:25 cr16-action-fileopen.png
> -rw-r--r-- 1 ach ach  1689 2006-01-06 20:25 cr22-action-fileopen.png
> -rw-r--r-- 1 ach ach  2888 2006-01-06 20:25 cr32-action-fileopen.png
> -rw-r--r-- 1 ach ach  5087 2006-01-06 20:25 cr48-action-fileopen.png
> -rw-r--r-- 1 ach ach  7525 2006-01-06 20:25 cr64-action-fileopen.png
> -rw-r--r-- 1 ach ach 28663 2006-01-08 19:01 crsc-action-fileopen.svgz
>
> is there a special reason why use for crystal a special fileopen
> (there no digikam equivalent for hires)
>

Before the integration, in digikam/digikam/pics, there is an icon called 
"importfolders2albums.png", I think it is the former icon of the menu 
"Album->Import->Import Folders..." but now, I don't know why, this 
icon is not used any more and the menu uses fileopen.png instead.

as I want to modify the icon of the menu "Album->Import->Import Folders...", I 
have to create a digikam/icons/crystalsvg/ folder to overwrite the global 
fileopen.png. It can be a bug because we can see the digikam fileopen.png 
everywhere the global fileopen.png is used (for exemple : Settings->Configure 
DigiKam->Collection).

Gilles, Joern, Tom, can we make a modification to use 
"importfolders2albums.png" for the menu 
"Album->Import->Import Folders..." ? Notice that I have also provided in the 
tarball :

cr128-action-importfolders2albums.png
cr16-action-importfolders2albums.png
cr22-action-importfolders2albums.png
cr32-action-importfolders2albums.png
cr48-action-importfolders2albums.png
cr64-action-importfolders2albums.png
crsc-action-importfolders2albums.svgz

to anticipate the modification.
---
Tung.