[Digikam-devel] New iconset integration for DigiKam 0.8.1 and 0.9.0

[Achim Bohnet]

On Monday 09 January 2006 14:19, Tung NGUYEN wrote:
> Hi Achim,
> 
> Do follow the following steps to integrate the new icons in DigiKam 0.8.1 :

working on it and testing right now.  Not commited yet.

> 
> 1) As you asked, the tarball http://ntung.free.fr/new-icons-0.8.1.tar.bz2 
> contains all the new icons (PNG and SVGZ) in the right pics folders in the 
> DigiKam tree.

Mhmm, make it's just the first time I noticed this:

a) make -f Makefile.cvs
...
unknown icon type  in digikam/digikam/pics/Makefile.in (tag.png)
unknown icon type histogram in digikam/digikam/pics/Makefile.in (histogram-lin.png)
unknown icon type histogram in digikam/digikam/pics/Makefile.in (histogram-log.png)
unknown icon type image in digikam/digikam/pics/Makefile.in (image-full.png)
unknown icon type image in digikam/digikam/pics/Makefile.in (image-selection.png)
unknown icon type  in digikam/digikam/pics/Makefile.in (image_broken.png)
unknown icon type  in digikam/digikam/pics/Makefile.in (rating.png)
unknown icon prefix tag in digikam/digikam/pics/Makefile.in
unknown icon prefix tag in digikam/digikam/pics/Makefile.in
unknown icon prefix tag in digikam/digikam/pics/Makefile.in
unknown icon prefix tag in digikam/digikam/pics/Makefile.in
unknown icon type showfoto in digikam/showfoto/pics/Makefile.in (showfoto-splash.png)
...

1) can't we simple rename tags(whatever).png to hi32-action-tags<whatever>.png
2) Stupid non programer question: why are the image* histogram* and ratin* icons
   installed into apps/digikam/data/  and not below the apps/digikam/icons tree
   as actions [+ a rename in as in 1)]

b) some icons have the 'x' bit set.  I will remove it.

c) In digikam/digikam/pics are also

-rw-r--r-- 1 ach ach 19430 2006-01-06 20:25 cr128-action-fileopen.png
-rw-r--r-- 1 ach ach  1065 2006-01-06 20:25 cr16-action-fileopen.png
-rw-r--r-- 1 ach ach  1689 2006-01-06 20:25 cr22-action-fileopen.png
-rw-r--r-- 1 ach ach  2888 2006-01-06 20:25 cr32-action-fileopen.png
-rw-r--r-- 1 ach ach  5087 2006-01-06 20:25 cr48-action-fileopen.png
-rw-r--r-- 1 ach ach  7525 2006-01-06 20:25 cr64-action-fileopen.png
-rw-r--r-- 1 ach ach 28663 2006-01-08 19:01 crsc-action-fileopen.svgz

is there a special reason why use for crystal a special fileopen
(there no digikam equivalent for hires)

Achim
> 
> 2) The file http://ntung.free.fr/new-icons-0.8.1.patch is used to patch the 
> file digikam/pics/Makefile.am.
> 
> 3) Once the new icons are integrated, you can delete the following obsolete 
> files:
> 
> - digikam/pics/addimagefolder.png
> - digikam/pics/albumfoldercomment.png
> - digikam/pics/albumfoldernew.png
> - digikam/pics/digitalcam.png
> - digikam/pics/editimage.png
> - digikam/pics/exifinfo.png
> - digikam/pics/histogram.png
> - digikam/pics/imagecomment.png
> - digikam/pics/importfolders2albums.png
> 
> ----------------------------------------------------------------------------
> Follow the same steps with http://ntung.free.fr/new-icons-0.9.0.tar.bz2 and 
> http://ntung.free.fr/new-icons-0.9.0.patch to integrate the new icons in 
> DigiKam 0.9.0.

I'll do this later until 0.8.1 merge is completed and tested.

Achim
> 
> ---
> Tung. 
> 
> 
> 
> 
> 
> 

-- 
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- reddy at lion.austin.ibm.com