[Digikam-devel] [Bug 110514] Enhanced selection, refactored histogram

[Gilles Caulier]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=110514         




------- Additional Comments From caulier.gilles free fr  2005-08-11 16:00 -------
-Point 1 : good sound... Implementation not yet checked !

-Point 2 : Take a care to use common ImageHistogram implementation.

-Point 3 : Definitivly NO. You need to use a separate thread againsty GUI thread. If you want to compute an histogram from a very large image (8/10 MPix for example), image editor will be frozen. Always use Qthread in this case. You can use my ThreadedImageFilter implementation in libs/imagefilter for example. Note that Qt4 will simplify QThread management using signal and slots ! Qthread will be derived from QObject.

-Point 4 : Add this mode to the common implementation, and updated all other histogram rendering accordingly. digiKam must be stay homogenous! I recommend you to remove temporally this implementation.

-Point 5 : Good sound.

In General (implementation just checked, not compiled):

- In imageHistogram.cpp : no need to recreate histogram computation implementation with your ImageHistogramData class... You must use the current implementation like it's used by other digiKam/DigikamImagePlugins parts (try grep for more info).

Take a care : The current histogram implementation is common to digiKam. If you want add more methods, patch current ImageHistogram implementation.

- Don't forget to use Digikam namespace.

- Never use std::cerr, use Kdebug instead.

- In the future, digiKam will be support 16/bits/color/pixels image file format using a new embedded framework named DImage instead QImage/imlib2. It's important to use a common implementation about histogram computation. 

- Why not using my histogram widget to rendering histogram on image editor canvas ? It's a common object...

- Don't forget to try your implementation with ShowFoto.

Gilles Caulier