Review Request 122564: Use Qt macros

Andrea Scarpino scarpino at kde.org
Sun Feb 15 07:40:01 UTC 2015



> On Feb. 15, 2015, 3:23 a.m., Mehrdad Momeny wrote:
> > Why are you changing these? is there any conflict?

At first I thought this was a requirement for kf5 applications, but turns out it is only a requirement for libraries, not applications.

But still, I remember this post about Q_FOREACH use http://tsdgeos.blogspot.it/2008/04/qforeach-is-your-friend.html?m=1 and another one that suggests to use qt macros for slot/signals to avoid conflicts with 3rd parties.


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122564/#review76036
-----------------------------------------------------------


On Feb. 13, 2015, 8:50 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122564/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 8:50 p.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> foreach -> Q_FOREACH
> emit -> Q_EMIT
> slots -> Q_SLOTS
> signals -> Q_SIGNALS
> 
> 
> Diffs
> -----
> 
>   microblogs/ocs/ocsmicroblog.h 87741b3b8dd5fecc3405b9262dc7a20a0fea7c62 
>   microblogs/ocs/ocsconfigurewidget.cpp 5f90815da5398a0bac70b10be13df1c78e826bb6 
>   microblogs/ocs/ocsconfigurewidget.h f2d46953a9fa4ab16c146393c54fdb2f521fc75c 
>   microblogs/laconica/laconicaeditaccount.h ef06d2e7decb6bfaaa73a12f3dc5ca44481057e8 
>   microblogs/laconica/laconicaeditaccount.cpp 2f36019f9479a4155d74791fbd7f381ec1a38c4b 
>   microblogs/laconica/laconicamicroblog.cpp 607c2b22cf025fd901e2bbc3d00f56c377151663 
>   microblogs/laconica/laconicapostwidget.h ace2713a58a62815138b7573787e00fa73b7837d 
>   microblogs/laconica/laconicapostwidget.cpp 3d4c31bf056dab09662b1ce9d95b4ae561f02948 
>   microblogs/laconica/laconicasearch.h 7ba83ee6af3a550c2faddd4c5e843043d26f41cc 
>   microblogs/laconica/laconicasearch.cpp 4b1c9c9daa52b434184381c2261625087ce10fbb 
>   microblogs/ocs/ocsaccount.h 2b579bda4fe195a615610877dfa598ed4be5418b 
>   microblogs/laconica/laconicaconversationtimelinewidget.cpp d8c4a4d592fb209c8c64ab65b6264a34dbbe8d74 
>   libchoqok/ui/uploadmediadialog.cpp ad0f542caccc6a7196e0ea84be8c64cc0ecf9300 
>   libchoqok/ui/timelinewidget.cpp a3442a449794ea76cec24c7ae09413984fc8c88b 
>   libchoqok/ui/quickpost.cpp 83d7440e49f5e1a5b592e9415eedeaa0939e801d 
>   libchoqok/ui/textbrowser.cpp 756f1a542c14edf9052e2d31534ad6871eecd427 
>   libchoqok/ui/microblogwidget.cpp 35df8f0ee00bac76185d0ce81fcbfe06be17dee2 
>   libchoqok/ui/postwidget.cpp c03ad7abbcc583d134465326f8ffd34d84a4e2d5 
>   libchoqok/ui/choqoktabbar.cpp 97dca7fe239f82a106c51f0e331905272f4712ed 
>   libchoqok/ui/choqoktextedit.cpp 50bfe9bf3c1c1f657a119efa1fc565dda2354cac 
>   libchoqok/account.cpp 26f4245bdb103d620225e6c1a5b25ead8cec6725 
>   libchoqok/accountmanager.cpp cfc90dede33d2021bce1877aaff9e0da5fe89dc3 
>   libchoqok/choqokuiglobal.cpp 2693f821186301ddc0a8a9b4f5116639ba73a918 
>   libchoqok/indicatormanager.h 8618de759373c55b4b96e8ef9152e072607a96e6 
>   libchoqok/mediamanager.cpp 2cb5aefb7cf38db3207cc86952d8a1cf2a5713b4 
>   libchoqok/microblog.h a564daf9059df041786887473686b2e0c6daeaa2 
>   libchoqok/plugin.cpp 3f50499c33e6689cfa8fcfb9def2fdd2938faa63 
>   libchoqok/pluginmanager.cpp 7b4c4fb4cc96229964b54155c4990481815db9dd 
>   libchoqok/shortenmanager.cpp ae3b6f64a2b1ba0b42afdbb1e61fb8392cbe9da7 
>   libchoqok/ui/choqokmainwindow.cpp fd2817b9d39865ae9532a6995082265770c05a28 
>   libchoqok/ui/choqoktabbar.h 1c79aa82a8ca4062639a4398f9ede457726a8c48 
>   microblogs/laconica/laconicacomposerwidget.h 7edaa6b7bcfa8b5d0cb7592189cf0b9f8e471160 
>   microblogs/laconica/laconicaconversationtimelinewidget.h c6fd59375f33b292243da19562dd0b16db87c1fc 
>   choqok/choqokapplication.h c8a687e05a4453f1d013b50ae9766a4670137d49 
>   choqok/config/accounts/accountswidget.h 80992948dfc3d8a26bffc6a7326222d6a63d4b8a 
>   choqok/config/accounts/accountswidget.cpp b69d7f11ac70bec5f55d9b552098d528c1b6144a 
>   choqok/config/behavior/behaviorconfig_shorten.h edfce18ff5b85b48f23dbcdc907805c7db0e28e1 
>   choqok/config/behavior/behaviorconfig_shorten.cpp a529c53d1c45c6cb87490ceb23884148852dcfab 
>   choqok/config/plugins/choqokpluginconfig.h f0729e74f5bd9557c6f28df52e560874a4a9e501 
>   choqok/mainwindow.h e28bc0c9aebb869e686eaddef4bb1f6dd22de435 
>   choqok/mainwindow.cpp 065615ce338480963f7650578510d78ca10746d2 
>   choqok/systrayicon.h 15a792d4fe3b958e43db2ec233ff2a29c8204a7b 
>   helperlibs/twitterapihelper/twitterapiaccount.cpp 7205a2bd657a61decef08aef1a1a1ba7d726041d 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp 419ecdd38d6d0504929fb935ab55c56d3e0f70c4 
>   helperlibs/twitterapihelper/twitterapimicroblogwidget.cpp db289942aff7c7a589821cea05b73d3f060007ce 
>   helperlibs/twitterapihelper/twitterapipostwidget.cpp 03ed3b03633adbb813e9d889f713013d8655d296 
>   helperlibs/twitterapihelper/twitterapisearchtimelinewidget.cpp 82dc1b187be2107b48b87003c33d7ae64aa562ad 
>   microblogs/twitter/twitterpostwidget.h af85c4d16ebba1ff98098a7e69f79ffb2d501639 
>   microblogs/twitter/twitterpostwidget.cpp a07b856cd34c935739849b940c450ff9c1c9129f 
>   microblogs/twitter/twittersearch.h 662e8d747c8a354ceb6cb280ad841a81dc1a1feb 
>   microblogs/twitter/twittersearch.cpp da85565e74d0f5baec28911097a08f4ae292f0ca 
>   plugins/betternotify/dummynotification.h 69de64afbd5db9c550033b43fc2a2f4b2751a527 
>   plugins/betternotify/dummynotification.cpp 587d11771c43af72ba7217cc1c43daf7845d1ac4 
>   plugins/betternotify/mytextbrowser.h 3d21c860a619c619f9b669d6909574f69eebd204 
>   plugins/betternotify/mytextbrowser.cpp eee0493a6d5c90c43cfaf39be6021674c09c57a0 
>   plugins/betternotify/notification.h b5186bed08627e01d5d057d264bed4294fa3c964 
>   plugins/betternotify/notification.cpp 816ad9a36a14e5e22efb7f0aff4223cb41abd82a 
>   plugins/betternotify/notify.h 17f6e2ff2f57ed56b51032c42c2105e87d15a88d 
>   plugins/betternotify/notifyconfig.h 1986946f3799756af9d86e0c7eccbccae08b0bd1 
>   plugins/betternotify/notifyconfig.cpp 76adaa6dd3c464b6ecabb4f889a16b364f0d46a6 
>   plugins/betternotify/notifysettings.cpp 84b08a39eb2f37c459648d80114855c7d8defaf3 
>   plugins/filter/addeditfilter.h 87e031bab75f31225bca0406d09b10fe507d1391 
>   plugins/filter/addeditfilter.cpp 913c854c95f4ec9419d3635e39984115236177df 
>   plugins/filter/configurefilters.h 0fb6c64620260446d06f8fb136d60d626cf38e78 
>   plugins/filter/configurefilters.cpp c30a84d92ab75339751011be3fe51dc8a90664c8 
>   plugins/uploaders/twitpic/twitpic.cpp a91c5ef0ecacadc843ff0ee954429050a7bc1861 
>   plugins/uploaders/twitpic/twitpicconfig.h 18c0ae1d87dafb2c23ec31256ee641f51e2bfa11 
>   plugins/uploaders/twitpic/twitpicconfig.cpp d788b38a9121453cecc8384c0a34f5cb6f82f6ae 
>   plugins/videopreview/videopreview.h 58ed2aa85c2dcb531195c7074848156a6ee93d8f 
>   plugins/videopreview/videopreview.cpp 952fa042894bcb34612f7d98ccb8cac1d2679c6e 
>   plugins/uploaders/posterous/posterous.cpp bb4917e3d19b2f38db8c21f4e6afe394bc6147be 
>   plugins/uploaders/posterous/posterousconfig.h 49b81804d4c02d157d39f4d2a7588fc1fb5a0da0 
>   plugins/uploaders/posterous/posterousconfig.cpp 309f549dccc8940ae4223895c1e5f7f041b549e6 
>   plugins/uploaders/twitgoo/twitgoo.h e1b1fc5315b6861e4056c2e71a1c0e15ea268b05 
>   plugins/uploaders/twitgoo/twitgoo.cpp 65766e99bd7c25efcc9f0e5ba65701184c9f4945 
>   plugins/uploaders/twitgoo/twitgooconfig.h ca5aefac6a2fe6879b2e6895032fbd58c2a6de8f 
>   plugins/uploaders/twitgoo/twitgooconfig.cpp a7bf3404c483061dc4ed924dfc59c69d62ef0fa9 
>   plugins/uploaders/twitpic/twitpic.h d63e6304ca852c42316c14d551415460b92448a1 
>   plugins/uploaders/imageshack/imageshack.cpp 22cde14361cce552f7c610610478217c16aca487 
>   plugins/uploaders/mobypicture/mobypicture.h 6dd7023c642d2ec77e43e2459dde2947d819f4fd 
>   plugins/uploaders/mobypicture/mobypicture.cpp be33f1da5c3da8cf2f3636270053f253cc26c4f9 
>   plugins/uploaders/mobypicture/mobypictureconfig.h 340afd7d8c38aae7799194b738e3f949be47c565 
>   plugins/uploaders/mobypicture/mobypictureconfig.cpp de28529f7d0e1f78344d56fbe320ecad89a9b411 
>   plugins/uploaders/posterous/posterous.h 2f55b8adc88c3764f687b4106420b8e7a1af30a6 
>   plugins/translator/translator.cpp d0b43203c3d64f86effca89f161a247826cfe5d8 
>   plugins/translator/translatorconfig.h 65db41da1634f1dab8a9a51cdc3a3d4190458b0b 
>   plugins/translator/translatorconfig.cpp daeabbb374790a450ad6edb1c77cba2aa46805ac 
>   plugins/untiny/untiny.h 886131042b64181bcf385897efc1c087567376f9 
>   plugins/untiny/untiny.cpp c5e8a3e4843dc881759de7bfcbc7bb5d16337ea3 
>   plugins/untiny/untinyconfig.h d010a6dfbfdf720e033348bc1d419cf67692fd00 
>   plugins/untiny/untinyconfig.cpp 947df50209f198ea79f4001ad7caef15eb812f62 
>   plugins/uploaders/flickr/flickr.h 6fd3d644d90cce8277ad8008c15c161b442721d5 
>   plugins/uploaders/flickr/flickr.cpp f0312e3dfdb7ede39c73e6ca19dbf2fd42124fbd 
>   plugins/uploaders/flickr/flickrconfig.h 1e2a78f81928427c9428fddce3dd0e5b166107b0 
>   plugins/uploaders/flickr/flickrconfig.cpp 9f0d920f3c2bdd26cd940f3ef84f68d438cf52d3 
>   plugins/uploaders/imageshack/imageshack.h 0646551197e48a819a4bc48ce5f1c5f2543fd5a7 
>   plugins/shorteners/tinyarro_ws/tinyarro_ws_config.h d6367390fa8bc4cb8faeb653af1ba95549b51be1 
>   plugins/shorteners/tinyarro_ws/tinyarro_ws_config.cpp e26de24f9bdffaac54197080a36093245119068d 
>   plugins/shorteners/yourls/yourls.h b3e7e6b403447bba6d5169a91f58b7cbd6bee263 
>   plugins/shorteners/yourls/yourlsconfig.h 5d4b7ddb0de6630711e742f34184dfc068a795f2 
>   plugins/shorteners/yourls/yourlsconfig.cpp dd8655f62c6577dcfb4d0877684a00f04a233827 
>   plugins/translator/translator.h 6aaf5033ce9d98f1064e0b04032fa71175168d0a 
>   plugins/nowlistening/nowlistening.h 89f4cb02e40adac04d26a4f2297abcad6fe576e1 
>   plugins/nowlistening/nowlisteningconfig.h 93201fa9896356a985c350079d13e1e7dc396777 
>   plugins/nowlistening/nowlisteningconfig.cpp fe9d0ded9fd9e3051e796e4605c1b0c56110359d 
>   plugins/quickfilter/quickfilter.h 5c99f9cf8de5ec29af508f5d0317b41998e40838 
>   plugins/quickfilter/quickfilter.cpp 2b8b74935e89ca1d5a3591e02ef2881b547b462a 
>   plugins/searchaction/searchaction.h 9d1e51c0ac03142281d7027f7d76265b1e3f55db 
>   plugins/shorteners/bit_ly/bit_ly_config.h 6c775585c090db21750f80c76c6aa44235ee98f9 
>   plugins/shorteners/bit_ly/bit_ly_config.cpp 4b44e0c12be4e389b4da47131ecc73464785f25c 
>   plugins/shorteners/is_gd/is_gd_config.h 1fbe06bead8518aaf80173ee68e48454049a868c 
>   plugins/shorteners/is_gd/is_gd_config.cpp 86c9578b7f6fc2bddda7b1fe819b62cf2875d10c 
>   plugins/imstatus/imqdbus.h 890184a6f8807034794cf9f260cb78b92aa88b47 
>   plugins/imstatus/imqdbus.cpp 7c78b34311af0bd329e00445a6da52f29165aa9c 
>   plugins/imstatus/imstatus.h 7717814ae9bd1ce679544a095b6dcb585ac94b02 
>   plugins/imstatus/imstatusconfig.h 7ed9b7f8bbb5c35dc351f678e5c9c6743862d719 
>   plugins/imstatus/imstatusconfig.cpp 9e35da86da24c4e47cae9f846bfe3201dd3988f4 
>   plugins/filter/filtermanager.h a50172dca0cbf543f7cee0c1708fc5997b251e81 
>   plugins/filter/filtermanager.cpp bb4faeeb14ec9769fc0f17260725d1523efa4e69 
>   plugins/filter/filtersettings.cpp fd0599d644c50c49ac70815d28c12a7897db5b39 
>   plugins/imagepreview/imagepreview.h 2e42c4ce8fcd63ac9f1317581c37efa3b6121739 
>   plugins/imagepreview/imagepreview.cpp 3bd0efc0320138603106b83cebab4afb7264bcdc 
>   microblogs/twitter/twittereditaccount.cpp 05f3ca6ab06e32be2e81ccc139b9f8eccbea6422 
>   microblogs/twitter/twitterlistdialog.h 6f0e3ff53c561920ae47f28662695b32ba178772 
>   microblogs/twitter/twittermicroblog.h cac2a169ecbb6eb6b4289d9940451f166dcb8815 
>   microblogs/twitter/twittermicroblog.cpp d646676fa88624af2a9b44f407f12bc6039b35ae 
>   microblogs/twitter/twitteraccount.cpp 41606821dfb4c3f8ef3164fb887df2f1efcd4df5 
>   microblogs/twitter/twittercomposerwidget.h 0b0530d04a8ca977e4a67d285e1914f1251e79ad 
>   microblogs/twitter/twittereditaccount.h 04b15b0ee860a82fb6c48323266711412c519fba 
>   microblogs/ocs/ocsmicroblog.cpp 3930f7fcf1a44a7447f4f891487567826ca3a0a2 
>   microblogs/pumpio/pumpiomicroblog.cpp c4118fdda0162ef9e3ad36b5297f18df31221c30 
>   microblogs/pumpio/pumpiopostwidget.cpp 4650f0f0567a9042eb25cc9673ec2b3cefe44247 
> 
> Diff: https://git.reviewboard.kde.org/r/122564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20150215/2a608717/attachment-0001.html>


More information about the Choqok-devel mailing list