<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122564/">https://git.reviewboard.kde.org/r/122564/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 15th, 2015, 3:23 a.m. CET, <b>Mehrdad Momeny</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why are you changing these? is there any conflict?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At first I thought this was a requirement for kf5 applications, but turns out it is only a requirement for libraries, not applications.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But still, I remember this post about Q_FOREACH use http://tsdgeos.blogspot.it/2008/04/qforeach-is-your-friend.html?m=1 and another one that suggests to use qt macros for slot/signals to avoid conflicts with 3rd parties.</p></pre>
<br />
<p>- Andrea</p>
<br />
<p>On February 13th, 2015, 8:50 p.m. CET, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Choqok.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2015, 8:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
choqok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">foreach -> Q_FOREACH
emit -> Q_EMIT
slots -> Q_SLOTS
signals -> Q_SIGNALS</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>microblogs/ocs/ocsmicroblog.h <span style="color: grey">(87741b3b8dd5fecc3405b9262dc7a20a0fea7c62)</span></li>
<li>microblogs/ocs/ocsconfigurewidget.cpp <span style="color: grey">(5f90815da5398a0bac70b10be13df1c78e826bb6)</span></li>
<li>microblogs/ocs/ocsconfigurewidget.h <span style="color: grey">(f2d46953a9fa4ab16c146393c54fdb2f521fc75c)</span></li>
<li>microblogs/laconica/laconicaeditaccount.h <span style="color: grey">(ef06d2e7decb6bfaaa73a12f3dc5ca44481057e8)</span></li>
<li>microblogs/laconica/laconicaeditaccount.cpp <span style="color: grey">(2f36019f9479a4155d74791fbd7f381ec1a38c4b)</span></li>
<li>microblogs/laconica/laconicamicroblog.cpp <span style="color: grey">(607c2b22cf025fd901e2bbc3d00f56c377151663)</span></li>
<li>microblogs/laconica/laconicapostwidget.h <span style="color: grey">(ace2713a58a62815138b7573787e00fa73b7837d)</span></li>
<li>microblogs/laconica/laconicapostwidget.cpp <span style="color: grey">(3d4c31bf056dab09662b1ce9d95b4ae561f02948)</span></li>
<li>microblogs/laconica/laconicasearch.h <span style="color: grey">(7ba83ee6af3a550c2faddd4c5e843043d26f41cc)</span></li>
<li>microblogs/laconica/laconicasearch.cpp <span style="color: grey">(4b1c9c9daa52b434184381c2261625087ce10fbb)</span></li>
<li>microblogs/ocs/ocsaccount.h <span style="color: grey">(2b579bda4fe195a615610877dfa598ed4be5418b)</span></li>
<li>microblogs/laconica/laconicaconversationtimelinewidget.cpp <span style="color: grey">(d8c4a4d592fb209c8c64ab65b6264a34dbbe8d74)</span></li>
<li>libchoqok/ui/uploadmediadialog.cpp <span style="color: grey">(ad0f542caccc6a7196e0ea84be8c64cc0ecf9300)</span></li>
<li>libchoqok/ui/timelinewidget.cpp <span style="color: grey">(a3442a449794ea76cec24c7ae09413984fc8c88b)</span></li>
<li>libchoqok/ui/quickpost.cpp <span style="color: grey">(83d7440e49f5e1a5b592e9415eedeaa0939e801d)</span></li>
<li>libchoqok/ui/textbrowser.cpp <span style="color: grey">(756f1a542c14edf9052e2d31534ad6871eecd427)</span></li>
<li>libchoqok/ui/microblogwidget.cpp <span style="color: grey">(35df8f0ee00bac76185d0ce81fcbfe06be17dee2)</span></li>
<li>libchoqok/ui/postwidget.cpp <span style="color: grey">(c03ad7abbcc583d134465326f8ffd34d84a4e2d5)</span></li>
<li>libchoqok/ui/choqoktabbar.cpp <span style="color: grey">(97dca7fe239f82a106c51f0e331905272f4712ed)</span></li>
<li>libchoqok/ui/choqoktextedit.cpp <span style="color: grey">(50bfe9bf3c1c1f657a119efa1fc565dda2354cac)</span></li>
<li>libchoqok/account.cpp <span style="color: grey">(26f4245bdb103d620225e6c1a5b25ead8cec6725)</span></li>
<li>libchoqok/accountmanager.cpp <span style="color: grey">(cfc90dede33d2021bce1877aaff9e0da5fe89dc3)</span></li>
<li>libchoqok/choqokuiglobal.cpp <span style="color: grey">(2693f821186301ddc0a8a9b4f5116639ba73a918)</span></li>
<li>libchoqok/indicatormanager.h <span style="color: grey">(8618de759373c55b4b96e8ef9152e072607a96e6)</span></li>
<li>libchoqok/mediamanager.cpp <span style="color: grey">(2cb5aefb7cf38db3207cc86952d8a1cf2a5713b4)</span></li>
<li>libchoqok/microblog.h <span style="color: grey">(a564daf9059df041786887473686b2e0c6daeaa2)</span></li>
<li>libchoqok/plugin.cpp <span style="color: grey">(3f50499c33e6689cfa8fcfb9def2fdd2938faa63)</span></li>
<li>libchoqok/pluginmanager.cpp <span style="color: grey">(7b4c4fb4cc96229964b54155c4990481815db9dd)</span></li>
<li>libchoqok/shortenmanager.cpp <span style="color: grey">(ae3b6f64a2b1ba0b42afdbb1e61fb8392cbe9da7)</span></li>
<li>libchoqok/ui/choqokmainwindow.cpp <span style="color: grey">(fd2817b9d39865ae9532a6995082265770c05a28)</span></li>
<li>libchoqok/ui/choqoktabbar.h <span style="color: grey">(1c79aa82a8ca4062639a4398f9ede457726a8c48)</span></li>
<li>microblogs/laconica/laconicacomposerwidget.h <span style="color: grey">(7edaa6b7bcfa8b5d0cb7592189cf0b9f8e471160)</span></li>
<li>microblogs/laconica/laconicaconversationtimelinewidget.h <span style="color: grey">(c6fd59375f33b292243da19562dd0b16db87c1fc)</span></li>
<li>choqok/choqokapplication.h <span style="color: grey">(c8a687e05a4453f1d013b50ae9766a4670137d49)</span></li>
<li>choqok/config/accounts/accountswidget.h <span style="color: grey">(80992948dfc3d8a26bffc6a7326222d6a63d4b8a)</span></li>
<li>choqok/config/accounts/accountswidget.cpp <span style="color: grey">(b69d7f11ac70bec5f55d9b552098d528c1b6144a)</span></li>
<li>choqok/config/behavior/behaviorconfig_shorten.h <span style="color: grey">(edfce18ff5b85b48f23dbcdc907805c7db0e28e1)</span></li>
<li>choqok/config/behavior/behaviorconfig_shorten.cpp <span style="color: grey">(a529c53d1c45c6cb87490ceb23884148852dcfab)</span></li>
<li>choqok/config/plugins/choqokpluginconfig.h <span style="color: grey">(f0729e74f5bd9557c6f28df52e560874a4a9e501)</span></li>
<li>choqok/mainwindow.h <span style="color: grey">(e28bc0c9aebb869e686eaddef4bb1f6dd22de435)</span></li>
<li>choqok/mainwindow.cpp <span style="color: grey">(065615ce338480963f7650578510d78ca10746d2)</span></li>
<li>choqok/systrayicon.h <span style="color: grey">(15a792d4fe3b958e43db2ec233ff2a29c8204a7b)</span></li>
<li>helperlibs/twitterapihelper/twitterapiaccount.cpp <span style="color: grey">(7205a2bd657a61decef08aef1a1a1ba7d726041d)</span></li>
<li>helperlibs/twitterapihelper/twitterapimicroblog.cpp <span style="color: grey">(419ecdd38d6d0504929fb935ab55c56d3e0f70c4)</span></li>
<li>helperlibs/twitterapihelper/twitterapimicroblogwidget.cpp <span style="color: grey">(db289942aff7c7a589821cea05b73d3f060007ce)</span></li>
<li>helperlibs/twitterapihelper/twitterapipostwidget.cpp <span style="color: grey">(03ed3b03633adbb813e9d889f713013d8655d296)</span></li>
<li>helperlibs/twitterapihelper/twitterapisearchtimelinewidget.cpp <span style="color: grey">(82dc1b187be2107b48b87003c33d7ae64aa562ad)</span></li>
<li>microblogs/twitter/twitterpostwidget.h <span style="color: grey">(af85c4d16ebba1ff98098a7e69f79ffb2d501639)</span></li>
<li>microblogs/twitter/twitterpostwidget.cpp <span style="color: grey">(a07b856cd34c935739849b940c450ff9c1c9129f)</span></li>
<li>microblogs/twitter/twittersearch.h <span style="color: grey">(662e8d747c8a354ceb6cb280ad841a81dc1a1feb)</span></li>
<li>microblogs/twitter/twittersearch.cpp <span style="color: grey">(da85565e74d0f5baec28911097a08f4ae292f0ca)</span></li>
<li>plugins/betternotify/dummynotification.h <span style="color: grey">(69de64afbd5db9c550033b43fc2a2f4b2751a527)</span></li>
<li>plugins/betternotify/dummynotification.cpp <span style="color: grey">(587d11771c43af72ba7217cc1c43daf7845d1ac4)</span></li>
<li>plugins/betternotify/mytextbrowser.h <span style="color: grey">(3d21c860a619c619f9b669d6909574f69eebd204)</span></li>
<li>plugins/betternotify/mytextbrowser.cpp <span style="color: grey">(eee0493a6d5c90c43cfaf39be6021674c09c57a0)</span></li>
<li>plugins/betternotify/notification.h <span style="color: grey">(b5186bed08627e01d5d057d264bed4294fa3c964)</span></li>
<li>plugins/betternotify/notification.cpp <span style="color: grey">(816ad9a36a14e5e22efb7f0aff4223cb41abd82a)</span></li>
<li>plugins/betternotify/notify.h <span style="color: grey">(17f6e2ff2f57ed56b51032c42c2105e87d15a88d)</span></li>
<li>plugins/betternotify/notifyconfig.h <span style="color: grey">(1986946f3799756af9d86e0c7eccbccae08b0bd1)</span></li>
<li>plugins/betternotify/notifyconfig.cpp <span style="color: grey">(76adaa6dd3c464b6ecabb4f889a16b364f0d46a6)</span></li>
<li>plugins/betternotify/notifysettings.cpp <span style="color: grey">(84b08a39eb2f37c459648d80114855c7d8defaf3)</span></li>
<li>plugins/filter/addeditfilter.h <span style="color: grey">(87e031bab75f31225bca0406d09b10fe507d1391)</span></li>
<li>plugins/filter/addeditfilter.cpp <span style="color: grey">(913c854c95f4ec9419d3635e39984115236177df)</span></li>
<li>plugins/filter/configurefilters.h <span style="color: grey">(0fb6c64620260446d06f8fb136d60d626cf38e78)</span></li>
<li>plugins/filter/configurefilters.cpp <span style="color: grey">(c30a84d92ab75339751011be3fe51dc8a90664c8)</span></li>
<li>plugins/uploaders/twitpic/twitpic.cpp <span style="color: grey">(a91c5ef0ecacadc843ff0ee954429050a7bc1861)</span></li>
<li>plugins/uploaders/twitpic/twitpicconfig.h <span style="color: grey">(18c0ae1d87dafb2c23ec31256ee641f51e2bfa11)</span></li>
<li>plugins/uploaders/twitpic/twitpicconfig.cpp <span style="color: grey">(d788b38a9121453cecc8384c0a34f5cb6f82f6ae)</span></li>
<li>plugins/videopreview/videopreview.h <span style="color: grey">(58ed2aa85c2dcb531195c7074848156a6ee93d8f)</span></li>
<li>plugins/videopreview/videopreview.cpp <span style="color: grey">(952fa042894bcb34612f7d98ccb8cac1d2679c6e)</span></li>
<li>plugins/uploaders/posterous/posterous.cpp <span style="color: grey">(bb4917e3d19b2f38db8c21f4e6afe394bc6147be)</span></li>
<li>plugins/uploaders/posterous/posterousconfig.h <span style="color: grey">(49b81804d4c02d157d39f4d2a7588fc1fb5a0da0)</span></li>
<li>plugins/uploaders/posterous/posterousconfig.cpp <span style="color: grey">(309f549dccc8940ae4223895c1e5f7f041b549e6)</span></li>
<li>plugins/uploaders/twitgoo/twitgoo.h <span style="color: grey">(e1b1fc5315b6861e4056c2e71a1c0e15ea268b05)</span></li>
<li>plugins/uploaders/twitgoo/twitgoo.cpp <span style="color: grey">(65766e99bd7c25efcc9f0e5ba65701184c9f4945)</span></li>
<li>plugins/uploaders/twitgoo/twitgooconfig.h <span style="color: grey">(ca5aefac6a2fe6879b2e6895032fbd58c2a6de8f)</span></li>
<li>plugins/uploaders/twitgoo/twitgooconfig.cpp <span style="color: grey">(a7bf3404c483061dc4ed924dfc59c69d62ef0fa9)</span></li>
<li>plugins/uploaders/twitpic/twitpic.h <span style="color: grey">(d63e6304ca852c42316c14d551415460b92448a1)</span></li>
<li>plugins/uploaders/imageshack/imageshack.cpp <span style="color: grey">(22cde14361cce552f7c610610478217c16aca487)</span></li>
<li>plugins/uploaders/mobypicture/mobypicture.h <span style="color: grey">(6dd7023c642d2ec77e43e2459dde2947d819f4fd)</span></li>
<li>plugins/uploaders/mobypicture/mobypicture.cpp <span style="color: grey">(be33f1da5c3da8cf2f3636270053f253cc26c4f9)</span></li>
<li>plugins/uploaders/mobypicture/mobypictureconfig.h <span style="color: grey">(340afd7d8c38aae7799194b738e3f949be47c565)</span></li>
<li>plugins/uploaders/mobypicture/mobypictureconfig.cpp <span style="color: grey">(de28529f7d0e1f78344d56fbe320ecad89a9b411)</span></li>
<li>plugins/uploaders/posterous/posterous.h <span style="color: grey">(2f55b8adc88c3764f687b4106420b8e7a1af30a6)</span></li>
<li>plugins/translator/translator.cpp <span style="color: grey">(d0b43203c3d64f86effca89f161a247826cfe5d8)</span></li>
<li>plugins/translator/translatorconfig.h <span style="color: grey">(65db41da1634f1dab8a9a51cdc3a3d4190458b0b)</span></li>
<li>plugins/translator/translatorconfig.cpp <span style="color: grey">(daeabbb374790a450ad6edb1c77cba2aa46805ac)</span></li>
<li>plugins/untiny/untiny.h <span style="color: grey">(886131042b64181bcf385897efc1c087567376f9)</span></li>
<li>plugins/untiny/untiny.cpp <span style="color: grey">(c5e8a3e4843dc881759de7bfcbc7bb5d16337ea3)</span></li>
<li>plugins/untiny/untinyconfig.h <span style="color: grey">(d010a6dfbfdf720e033348bc1d419cf67692fd00)</span></li>
<li>plugins/untiny/untinyconfig.cpp <span style="color: grey">(947df50209f198ea79f4001ad7caef15eb812f62)</span></li>
<li>plugins/uploaders/flickr/flickr.h <span style="color: grey">(6fd3d644d90cce8277ad8008c15c161b442721d5)</span></li>
<li>plugins/uploaders/flickr/flickr.cpp <span style="color: grey">(f0312e3dfdb7ede39c73e6ca19dbf2fd42124fbd)</span></li>
<li>plugins/uploaders/flickr/flickrconfig.h <span style="color: grey">(1e2a78f81928427c9428fddce3dd0e5b166107b0)</span></li>
<li>plugins/uploaders/flickr/flickrconfig.cpp <span style="color: grey">(9f0d920f3c2bdd26cd940f3ef84f68d438cf52d3)</span></li>
<li>plugins/uploaders/imageshack/imageshack.h <span style="color: grey">(0646551197e48a819a4bc48ce5f1c5f2543fd5a7)</span></li>
<li>plugins/shorteners/tinyarro_ws/tinyarro_ws_config.h <span style="color: grey">(d6367390fa8bc4cb8faeb653af1ba95549b51be1)</span></li>
<li>plugins/shorteners/tinyarro_ws/tinyarro_ws_config.cpp <span style="color: grey">(e26de24f9bdffaac54197080a36093245119068d)</span></li>
<li>plugins/shorteners/yourls/yourls.h <span style="color: grey">(b3e7e6b403447bba6d5169a91f58b7cbd6bee263)</span></li>
<li>plugins/shorteners/yourls/yourlsconfig.h <span style="color: grey">(5d4b7ddb0de6630711e742f34184dfc068a795f2)</span></li>
<li>plugins/shorteners/yourls/yourlsconfig.cpp <span style="color: grey">(dd8655f62c6577dcfb4d0877684a00f04a233827)</span></li>
<li>plugins/translator/translator.h <span style="color: grey">(6aaf5033ce9d98f1064e0b04032fa71175168d0a)</span></li>
<li>plugins/nowlistening/nowlistening.h <span style="color: grey">(89f4cb02e40adac04d26a4f2297abcad6fe576e1)</span></li>
<li>plugins/nowlistening/nowlisteningconfig.h <span style="color: grey">(93201fa9896356a985c350079d13e1e7dc396777)</span></li>
<li>plugins/nowlistening/nowlisteningconfig.cpp <span style="color: grey">(fe9d0ded9fd9e3051e796e4605c1b0c56110359d)</span></li>
<li>plugins/quickfilter/quickfilter.h <span style="color: grey">(5c99f9cf8de5ec29af508f5d0317b41998e40838)</span></li>
<li>plugins/quickfilter/quickfilter.cpp <span style="color: grey">(2b8b74935e89ca1d5a3591e02ef2881b547b462a)</span></li>
<li>plugins/searchaction/searchaction.h <span style="color: grey">(9d1e51c0ac03142281d7027f7d76265b1e3f55db)</span></li>
<li>plugins/shorteners/bit_ly/bit_ly_config.h <span style="color: grey">(6c775585c090db21750f80c76c6aa44235ee98f9)</span></li>
<li>plugins/shorteners/bit_ly/bit_ly_config.cpp <span style="color: grey">(4b44e0c12be4e389b4da47131ecc73464785f25c)</span></li>
<li>plugins/shorteners/is_gd/is_gd_config.h <span style="color: grey">(1fbe06bead8518aaf80173ee68e48454049a868c)</span></li>
<li>plugins/shorteners/is_gd/is_gd_config.cpp <span style="color: grey">(86c9578b7f6fc2bddda7b1fe819b62cf2875d10c)</span></li>
<li>plugins/imstatus/imqdbus.h <span style="color: grey">(890184a6f8807034794cf9f260cb78b92aa88b47)</span></li>
<li>plugins/imstatus/imqdbus.cpp <span style="color: grey">(7c78b34311af0bd329e00445a6da52f29165aa9c)</span></li>
<li>plugins/imstatus/imstatus.h <span style="color: grey">(7717814ae9bd1ce679544a095b6dcb585ac94b02)</span></li>
<li>plugins/imstatus/imstatusconfig.h <span style="color: grey">(7ed9b7f8bbb5c35dc351f678e5c9c6743862d719)</span></li>
<li>plugins/imstatus/imstatusconfig.cpp <span style="color: grey">(9e35da86da24c4e47cae9f846bfe3201dd3988f4)</span></li>
<li>plugins/filter/filtermanager.h <span style="color: grey">(a50172dca0cbf543f7cee0c1708fc5997b251e81)</span></li>
<li>plugins/filter/filtermanager.cpp <span style="color: grey">(bb4faeeb14ec9769fc0f17260725d1523efa4e69)</span></li>
<li>plugins/filter/filtersettings.cpp <span style="color: grey">(fd0599d644c50c49ac70815d28c12a7897db5b39)</span></li>
<li>plugins/imagepreview/imagepreview.h <span style="color: grey">(2e42c4ce8fcd63ac9f1317581c37efa3b6121739)</span></li>
<li>plugins/imagepreview/imagepreview.cpp <span style="color: grey">(3bd0efc0320138603106b83cebab4afb7264bcdc)</span></li>
<li>microblogs/twitter/twittereditaccount.cpp <span style="color: grey">(05f3ca6ab06e32be2e81ccc139b9f8eccbea6422)</span></li>
<li>microblogs/twitter/twitterlistdialog.h <span style="color: grey">(6f0e3ff53c561920ae47f28662695b32ba178772)</span></li>
<li>microblogs/twitter/twittermicroblog.h <span style="color: grey">(cac2a169ecbb6eb6b4289d9940451f166dcb8815)</span></li>
<li>microblogs/twitter/twittermicroblog.cpp <span style="color: grey">(d646676fa88624af2a9b44f407f12bc6039b35ae)</span></li>
<li>microblogs/twitter/twitteraccount.cpp <span style="color: grey">(41606821dfb4c3f8ef3164fb887df2f1efcd4df5)</span></li>
<li>microblogs/twitter/twittercomposerwidget.h <span style="color: grey">(0b0530d04a8ca977e4a67d285e1914f1251e79ad)</span></li>
<li>microblogs/twitter/twittereditaccount.h <span style="color: grey">(04b15b0ee860a82fb6c48323266711412c519fba)</span></li>
<li>microblogs/ocs/ocsmicroblog.cpp <span style="color: grey">(3930f7fcf1a44a7447f4f891487567826ca3a0a2)</span></li>
<li>microblogs/pumpio/pumpiomicroblog.cpp <span style="color: grey">(c4118fdda0162ef9e3ad36b5297f18df31221c30)</span></li>
<li>microblogs/pumpio/pumpiopostwidget.cpp <span style="color: grey">(4650f0f0567a9042eb25cc9673ec2b3cefe44247)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122564/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>