Review Request 118535: Remove pop-up modal dialog error when starting choqok without internet connection

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118535/#review61341
-----------------------------------------------------------


This review has been submitted with commit ad83e24d2d0500c9c9c9e9abd5489a32efd29c18 by Lim Yuen Hoe to branch master.

- Commit Hook


On June 30, 2014, 5:44 p.m., Yuen Hoe Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118535/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 5:44 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> If choqok is started without internet connection, a pop up shows up saying "Friends list for account could not be updated", which is a little annoying since the status bar already has a similar error message - especially during start up where I always need to close the pop up as the first thing I do after logging into Plasma when there's no internet. Thought I'd try and investigate the code and I found it's because the friend list update error is, unlike other errors like failure to update timeline, emitted with severity "Critical". Changing this to "Low" like the others gets rid of the popup.
> 
> Is this an acceptable patch? Or is there an important reason the friends list update message is Critical? If so, then is there another better way I could patch choqok to avoid the pop up?
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblog.h e0765b2 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp 317f14b 
>   microblogs/laconica/laconicamicroblog.h 9d0d9e7 
>   microblogs/laconica/laconicamicroblog.cpp 7bdbd2d 
> 
> Diff: https://git.reviewboard.kde.org/r/118535/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yuen Hoe Lim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20140701/a09d1ec4/attachment.html>