<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118535/">https://git.reviewboard.kde.org/r/118535/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ad83e24d2d0500c9c9c9e9abd5489a32efd29c18 by Lim Yuen Hoe to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On June 30th, 2014, 5:44 p.m. UTC, Yuen Hoe Lim wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Choqok and Mehrdad Momeny.</div>
<div>By Yuen Hoe Lim.</div>
<p style="color: grey;"><i>Updated June 30, 2014, 5:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
choqok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If choqok is started without internet connection, a pop up shows up saying "Friends list for account could not be updated", which is a little annoying since the status bar already has a similar error message - especially during start up where I always need to close the pop up as the first thing I do after logging into Plasma when there's no internet. Thought I'd try and investigate the code and I found it's because the friend list update error is, unlike other errors like failure to update timeline, emitted with severity "Critical". Changing this to "Low" like the others gets rid of the popup.
Is this an acceptable patch? Or is there an important reason the friends list update message is Critical? If so, then is there another better way I could patch choqok to avoid the pop up?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>helperlibs/twitterapihelper/twitterapimicroblog.h <span style="color: grey">(e0765b2)</span></li>
<li>helperlibs/twitterapihelper/twitterapimicroblog.cpp <span style="color: grey">(317f14b)</span></li>
<li>microblogs/laconica/laconicamicroblog.h <span style="color: grey">(9d0d9e7)</span></li>
<li>microblogs/laconica/laconicamicroblog.cpp <span style="color: grey">(7bdbd2d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118535/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>