Review Request 121650: Query and save "followers" and use them for DM recipients rather than "friends"

[Mehrdad Momeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121650/#review72517
-----------------------------------------------------------

Ship it!


The rest seems fine,
Thanks


choqok-vanilla/helperlibs/twitterapihelper/twitterapiaccount.h
<https://git.reviewboard.kde.org/r/121650/#comment50562>

    Here are also some trailing spaces, could be removed.
    
    I guess you can set a setting in your editor to remove them by default. (At least in KDE editors(KDevelop, KWrite), there is such a option)


- Mehrdad Momeny


On Dec. 23, 2014, 5:36 p.m., Ian Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121650/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 5:36 p.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Right now, Choqok lists all "friends" (i.e.: people you have followed) as potential recipients for DMs. Twitter does not allow you to send DMs EXCEPT to people who are following YOU. This patch makes Choqok distinguish "followers" (following you) from "friends" (you are following) and lists only followers as potential recipients.
> 
> Based on https://reviewboard.kde.org/r/121165/.
> 
> 
> Diffs
> -----
> 
>   choqok-vanilla/helperlibs/twitterapihelper/twitterapiaccount.h d880f14 
>   choqok-vanilla/helperlibs/twitterapihelper/twitterapiaccount.cpp 7205a2b 
>   choqok-vanilla/helperlibs/twitterapihelper/twitterapidmessagedialog.h ed36a1d 
>   choqok-vanilla/helperlibs/twitterapihelper/twitterapidmessagedialog.cpp 6a8c045 
>   choqok-vanilla/helperlibs/twitterapihelper/twitterapimicroblog.h 75a9f77 
>   choqok-vanilla/helperlibs/twitterapihelper/twitterapimicroblog.cpp 419ecdd 
>   choqok-vanilla/microblogs/laconica/laconicamicroblog.cpp dd86db2 
> 
> Diff: https://git.reviewboard.kde.org/r/121650/diff/
> 
> 
> Testing
> -------
> 
> Compiles and seems to work.
> See also https://reviewboard.kde.org/r/121165/.
> 
> 
> Thanks,
> 
> Ian Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141226/c6f2cb4b/attachment.html>