<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121650/">https://git.reviewboard.kde.org/r/121650/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The rest seems fine,
Thanks</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121650/diff/1/?file=335506#file335506line74" style="color: black; font-weight: bold; text-decoration: underline;">choqok-newgit/helperlibs/twitterapihelper/twitterapiaccount.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">74</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here are also some trailing spaces, could be removed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess you can set a setting in your editor to remove them by default. (At least in KDE editors(KDevelop, KWrite), there is such a option)</p></pre>
</div>
</div>
<br />
<p>- Mehrdad Momeny</p>
<br />
<p>On December 23rd, 2014, 5:36 p.m. UTC, Ian Schwarz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Choqok.</div>
<div>By Ian Schwarz.</div>
<p style="color: grey;"><i>Updated Dec. 23, 2014, 5:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
choqok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Right now, Choqok lists all "friends" (i.e.: people you have followed) as potential recipients for DMs. Twitter does not allow you to send DMs EXCEPT to people who are following YOU. This patch makes Choqok distinguish "followers" (following you) from "friends" (you are following) and lists only followers as potential recipients.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Based on https://reviewboard.kde.org/r/121165/.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles and seems to work.
See also https://reviewboard.kde.org/r/121165/.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>choqok-vanilla/helperlibs/twitterapihelper/twitterapiaccount.h <span style="color: grey">(d880f14)</span></li>
<li>choqok-vanilla/helperlibs/twitterapihelper/twitterapiaccount.cpp <span style="color: grey">(7205a2b)</span></li>
<li>choqok-vanilla/helperlibs/twitterapihelper/twitterapidmessagedialog.h <span style="color: grey">(ed36a1d)</span></li>
<li>choqok-vanilla/helperlibs/twitterapihelper/twitterapidmessagedialog.cpp <span style="color: grey">(6a8c045)</span></li>
<li>choqok-vanilla/helperlibs/twitterapihelper/twitterapimicroblog.h <span style="color: grey">(75a9f77)</span></li>
<li>choqok-vanilla/helperlibs/twitterapihelper/twitterapimicroblog.cpp <span style="color: grey">(419ecdd)</span></li>
<li>choqok-vanilla/microblogs/laconica/laconicamicroblog.cpp <span style="color: grey">(dd86db2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121650/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>