Review Request 121579: KDE Telepathy support in IMStatus Plugin

[Mehrdad Momeny]

> On Dec. 17, 2014, 12:47 p.m., Ahmed I. Khalil wrote:
> > I've noticed that this plugin works only on statuses that comes from the QuickPostWidget. 
> > I'd like also the status be posted to IM services when using post widget inside the timeline, it would be great if someone could point me to the related classes so that I could implement that functionality.
> 
> Andrea Scarpino wrote:
>     Great, it works. I just tested this.
>     
>     
>     Yes, unfortunately there's no way to access the microblog's ComposerWidgets yet. You could add a getter in MicroBlog which points to the instance of the object created by createComposerWidget() (then every microblog service should set that attribute). I'm right Mehrdad?

Right now we get notified only from QuickPostWidget, but If we are going to get the signal also from the composer widgets, it's better to be a single way for all of them, I mean that we won't need to connect to every ComposerWidget and the QuickPost.
the good thing about the QuickPostWidget is that we only have one of it. but for ComposerWidget we have (at most)one per account.
I need to go through codes and find a good way to do that.

I think it's better to leave it as is for now.
I'll check it later and will update the plugins if a new signal added for composers too.


- Mehrdad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121579/#review72174
-----------------------------------------------------------


On Dec. 17, 2014, 4:20 p.m., Ahmed I. Khalil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121579/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 4:20 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Bugs: 301702
>     http://bugs.kde.org/show_bug.cgi?id=301702
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> Refactored the IMQDBus class to be suitable for use with TelepathyQt
> Added TelepathyQt as optional dependencies and if not found do not build the IMStatus plugin.
> 
> 
> Diffs
> -----
> 
>   plugins/imstatus/CMakeLists.txt 992977286608f32373c8858f57fa9335699046b7 
>   plugins/imstatus/config-imstatus.h.cmake PRE-CREATION 
>   plugins/imstatus/imqdbus.h 97e7b2f6a7809f294ffcc443822412be4ce2f7af 
>   plugins/imstatus/imqdbus.cpp ce2580bd9ea861cf0df8c3d31a4f3373cb312bd5 
>   plugins/imstatus/imstatus.h 5f49451387584ce7f8a8c917b38219e469cd25c2 
>   plugins/imstatus/imstatus.cpp e8817fed179a6a652a04096fe84412e843de3a13 
> 
> Diff: https://git.reviewboard.kde.org/r/121579/diff/
> 
> 
> Testing
> -------
> 
> Posted a post using the Quick post widget, and the status changed to all the online accounts in KDE Telepathy
> 
> 
> Thanks,
> 
> Ahmed I. Khalil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141218/817eed25/attachment.html>