<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121579/">https://git.reviewboard.kde.org/r/121579/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 17th, 2014, 12:47 p.m. UTC, <b>Ahmed I. Khalil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've noticed that this plugin works only on statuses that comes from the QuickPostWidget.
I'd like also the status be posted to IM services when using post widget inside the timeline, it would be great if someone could point me to the related classes so that I could implement that functionality.</p></pre>
</blockquote>
<p>On December 17th, 2014, 6:06 p.m. UTC, <b>Andrea Scarpino</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Great, it works. I just tested this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, unfortunately there's no way to access the microblog's ComposerWidgets yet. You could add a getter in MicroBlog which points to the instance of the object created by createComposerWidget() (then every microblog service should set that attribute). I'm right Mehrdad?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Right now we get notified only from QuickPostWidget, but If we are going to get the signal also from the composer widgets, it's better to be a single way for all of them, I mean that we won't need to connect to every ComposerWidget and the QuickPost.
the good thing about the QuickPostWidget is that we only have one of it. but for ComposerWidget we have (at most)one per account.
I need to go through codes and find a good way to do that.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think it's better to leave it as is for now.
I'll check it later and will update the plugins if a new signal added for composers too.</p></pre>
<br />
<p>- Mehrdad</p>
<br />
<p>On December 17th, 2014, 4:20 p.m. UTC, Ahmed I. Khalil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Choqok and Mehrdad Momeny.</div>
<div>By Ahmed I. Khalil.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2014, 4:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=301702">301702</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
choqok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Refactored the IMQDBus class to be suitable for use with TelepathyQt
Added TelepathyQt as optional dependencies and if not found do not build the IMStatus plugin.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Posted a post using the Quick post widget, and the status changed to all the online accounts in KDE Telepathy</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/imstatus/CMakeLists.txt <span style="color: grey">(992977286608f32373c8858f57fa9335699046b7)</span></li>
<li>plugins/imstatus/config-imstatus.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/imstatus/imqdbus.h <span style="color: grey">(97e7b2f6a7809f294ffcc443822412be4ce2f7af)</span></li>
<li>plugins/imstatus/imqdbus.cpp <span style="color: grey">(ce2580bd9ea861cf0df8c3d31a4f3373cb312bd5)</span></li>
<li>plugins/imstatus/imstatus.h <span style="color: grey">(5f49451387584ce7f8a8c917b38219e469cd25c2)</span></li>
<li>plugins/imstatus/imstatus.cpp <span style="color: grey">(e8817fed179a6a652a04096fe84412e843de3a13)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121579/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>