Review Request 121479: Get char limit for the composer from the status.net server

[Mehrdad Momeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121479/#review71946
-----------------------------------------------------------

Ship it!


Great,
Thanks

- Mehrdad Momeny


On Dec. 14, 2014, 9:05 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121479/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2014, 9:05 a.m.)
> 
> 
> Review request for Choqok.
> 
> 
> Bugs: 283298
>     http://bugs.kde.org/show_bug.cgi?id=283298
> 
> 
> Repository: choqok
> 
> 
> Description
> -------
> 
> I reworked #102222.
> 
> setCharLimit() has been moved from the MicroBlog to the Account class. It also has been renamed as setPostCharLimit().
> 
> I moved the setTextLimit function in the EditAccount widget. The change is then propagated to the ComposerWidget by the modified() signal, which listen on it and redraw the Editor.
> 
> Also, the HTTP job result is checked and only when it fails a fixed value (140) is set; unlimited text is allowed then.
> 
> Pump.IO account has been updated to the new API.
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapiaccount.cpp e2efe97d1e0aaac1321641d9284a679847a68ba2 
>   helperlibs/twitterapihelper/twitterapicomposerwidget.cpp 07341153a227c412af8a6e4f903ce83a409094e5 
>   helperlibs/twitterapihelper/twitterapidmessagedialog.cpp 70092db223a84d207a7a2cd306fee873338e3ca7 
>   microblogs/pumpio/pumpiocomposerwidget.cpp 53a11bce67e99977a885ece8cbcbc144853f9088 
>   microblogs/pumpio/pumpiomicroblog.cpp 98c4009ca8be7b78f90a37adaea34f6abaec7400 
>   microblogs/twitter/twittercomposerwidget.cpp e04a9f785b516d4dadddf7ad300ff2f17e0b81cd 
>   helperlibs/twitterapihelper/twitterapimicroblog.cpp ff507105f9050b7768ada2c486d595997895833b 
>   libchoqok/account.h de56ddfe83b7d4f2733eb84858342cdafd41cf1f 
>   libchoqok/account.cpp 7674c521a2913b184202bed373b8c6be2b07c995 
>   libchoqok/microblog.h 4c461999f5f5ec7d082d1f4c7bbd7a2d19258d27 
>   libchoqok/microblog.cpp fd9a1f9312cc8ceec300d697a7b64c8ba85c0366 
>   libchoqok/ui/composerwidget.cpp 79603eb13489287df5c7482435b8025aa97777ee 
>   libchoqok/ui/quickpost.cpp 0d1deb572d8a3163415d8a9323816d9a6a4bc4bc 
>   microblogs/laconica/CMakeLists.txt 5516c2bd83449f16392e3011f1d39339034aa21a 
>   microblogs/laconica/laconicacomposerwidget.h 59b354d4e2ba084d9495c295efa6b1f75838afde 
>   microblogs/laconica/laconicacomposerwidget.cpp 024b9f20502d72c038650dda030de92b6272993e 
>   microblogs/laconica/laconicaeditaccount.h c4a1c90e09e197b6dbc61a413cd2051147789ad0 
>   microblogs/laconica/laconicaeditaccount.cpp 9ad54709ad3ef46c555f223c76430bdbd052f522 
>   microblogs/pumpio/pumpioaccount.cpp 8cf74e4c4247ebeb73b1ac42f9684468bd4e9ac3 
> 
> Diff: https://git.reviewboard.kde.org/r/121479/diff/
> 
> 
> Testing
> -------
> 
> Registered an account on http://social.stopwatchingus-heidelberg.de (which has a limit on 500 chars).
> Counter is correctly set without a restart and it persists after a restart.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20141214/97fd81b4/attachment-0001.html>