<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121479/">https://git.reviewboard.kde.org/r/121479/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Great,
Thanks</p></pre>
<br />
<p>- Mehrdad Momeny</p>
<br />
<p>On December 14th, 2014, 9:05 a.m. UTC, Andrea Scarpino wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Choqok.</div>
<div>By Andrea Scarpino.</div>
<p style="color: grey;"><i>Updated Dec. 14, 2014, 9:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=283298">283298</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
choqok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I reworked #102222.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">setCharLimit() has been moved from the MicroBlog to the Account class. It also has been renamed as setPostCharLimit().</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I moved the setTextLimit function in the EditAccount widget. The change is then propagated to the ComposerWidget by the modified() signal, which listen on it and redraw the Editor.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, the HTTP job result is checked and only when it fails a fixed value (140) is set; unlimited text is allowed then.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Pump.IO account has been updated to the new API.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Registered an account on http://social.stopwatchingus-heidelberg.de (which has a limit on 500 chars).
Counter is correctly set without a restart and it persists after a restart.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>helperlibs/twitterapihelper/twitterapiaccount.cpp <span style="color: grey">(e2efe97d1e0aaac1321641d9284a679847a68ba2)</span></li>
<li>helperlibs/twitterapihelper/twitterapicomposerwidget.cpp <span style="color: grey">(07341153a227c412af8a6e4f903ce83a409094e5)</span></li>
<li>helperlibs/twitterapihelper/twitterapidmessagedialog.cpp <span style="color: grey">(70092db223a84d207a7a2cd306fee873338e3ca7)</span></li>
<li>microblogs/pumpio/pumpiocomposerwidget.cpp <span style="color: grey">(53a11bce67e99977a885ece8cbcbc144853f9088)</span></li>
<li>microblogs/pumpio/pumpiomicroblog.cpp <span style="color: grey">(98c4009ca8be7b78f90a37adaea34f6abaec7400)</span></li>
<li>microblogs/twitter/twittercomposerwidget.cpp <span style="color: grey">(e04a9f785b516d4dadddf7ad300ff2f17e0b81cd)</span></li>
<li>helperlibs/twitterapihelper/twitterapimicroblog.cpp <span style="color: grey">(ff507105f9050b7768ada2c486d595997895833b)</span></li>
<li>libchoqok/account.h <span style="color: grey">(de56ddfe83b7d4f2733eb84858342cdafd41cf1f)</span></li>
<li>libchoqok/account.cpp <span style="color: grey">(7674c521a2913b184202bed373b8c6be2b07c995)</span></li>
<li>libchoqok/microblog.h <span style="color: grey">(4c461999f5f5ec7d082d1f4c7bbd7a2d19258d27)</span></li>
<li>libchoqok/microblog.cpp <span style="color: grey">(fd9a1f9312cc8ceec300d697a7b64c8ba85c0366)</span></li>
<li>libchoqok/ui/composerwidget.cpp <span style="color: grey">(79603eb13489287df5c7482435b8025aa97777ee)</span></li>
<li>libchoqok/ui/quickpost.cpp <span style="color: grey">(0d1deb572d8a3163415d8a9323816d9a6a4bc4bc)</span></li>
<li>microblogs/laconica/CMakeLists.txt <span style="color: grey">(5516c2bd83449f16392e3011f1d39339034aa21a)</span></li>
<li>microblogs/laconica/laconicacomposerwidget.h <span style="color: grey">(59b354d4e2ba084d9495c295efa6b1f75838afde)</span></li>
<li>microblogs/laconica/laconicacomposerwidget.cpp <span style="color: grey">(024b9f20502d72c038650dda030de92b6272993e)</span></li>
<li>microblogs/laconica/laconicaeditaccount.h <span style="color: grey">(c4a1c90e09e197b6dbc61a413cd2051147789ad0)</span></li>
<li>microblogs/laconica/laconicaeditaccount.cpp <span style="color: grey">(9ad54709ad3ef46c555f223c76430bdbd052f522)</span></li>
<li>microblogs/pumpio/pumpioaccount.cpp <span style="color: grey">(8cf74e4c4247ebeb73b1ac42f9684468bd4e9ac3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121479/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>