Review Request 111181: Add 'mark as read' to timeline menu

[Mehrdad Momeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111181/#review35277
-----------------------------------------------------------

Ship it!


Hmm, I think showing this action/menu when there's no unread post in timeline is non-sense, isn't it!?
And now that you are fixing this, I suggest re-labling the "Mark all as read" button which placed besides More button, to "Mark all timelines as read"
and re-label this action as "Mark timeline as read" this would remove the ambiguity for users!

Hmm, If you have developer account,please do these changes and commit it, otherwise I will do it myself

- Mehrdad Momeny


On June 25, 2013, 5:18 p.m., Yuen Hoe Lim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111181/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 5:18 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Description
> -------
> 
> As requested in the bugtest/maillist: small patch to add a 'mark all as read' item to the timeline tab context menu.
> 
> 
> This addresses bug 287684.
>     http://bugs.kde.org/show_bug.cgi?id=287684
> 
> 
> Diffs
> -----
> 
>   helperlibs/twitterapihelper/twitterapimicroblogwidget.cpp 6e91e32 
> 
> Diff: http://git.reviewboard.kde.org/r/111181/diff/
> 
> 
> Testing
> -------
> 
> basic testing on my box.
> 
> 
> Thanks,
> 
> Yuen Hoe Lim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20130629/4726293a/attachment.html>