Review Request 111406: Choqok now supports sending and receiving multiline tweets

Ahmed Ibrahim ahmedibrahimkhali at gmail.com
Thu Jul 11 20:17:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111406/
-----------------------------------------------------------

(Updated July 11, 2013, 8:17 p.m.)


Review request for Choqok and Mehrdad Momeny.


Description
-------

Managed to add new line capabilities to Choqok's TextEdit class.
Replaced each "\n" occurence in the tweets content by a "br" tag.


This addresses bug 321493.
    http://bugs.kde.org/show_bug.cgi?id=321493


Diffs (updated)
-----

  libchoqok/ui/choqoktextedit.cpp 4ebe592 
  libchoqok/ui/postwidget.cpp 4f25834 

Diff: http://git.reviewboard.kde.org/r/111406/diff/


Testing
-------

Sent a multi-line tweet from Twitter's Web Client and received it correctly in Choqok.
Also sent a multi-line tweet from Choqok and found it displayed correctly on Twitter's web client.


File Attachments
----------------

A multiline tweet sent from Twitter web client and displayed in Choqok
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/05/Choqok_multiline.png


Thanks,

Ahmed Ibrahim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20130711/526d1edd/attachment.html>


More information about the Choqok-devel mailing list