Review Request 111406: Choqok now supports sending and receiving multiline tweets

[Mehrdad Momeny]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111406/#review35818
-----------------------------------------------------------

Ship it!


Ship It!


libchoqok/ui/choqoktextedit.cpp
<http://git.reviewboard.kde.org/r/111406/#comment26257>

    I think, it's nicer to write it this way:
    
    if ( e->key() == Qt::Key_Enter || e->key() == Qt::Key_Return )
    {
    if (e->modifiers() == Qt::ShiftModifier )
    {}
    else
    {}
    }


- Mehrdad Momeny


On July 5, 2013, 3:12 p.m., Ahmed Ibrahim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111406/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 3:12 p.m.)
> 
> 
> Review request for Choqok and Mehrdad Momeny.
> 
> 
> Description
> -------
> 
> Managed to add new line capabilities to Choqok's TextEdit class.
> Replaced each "\n" occurence in the tweets content by a "br" tag.
> 
> 
> This addresses bug 321493.
>     http://bugs.kde.org/show_bug.cgi?id=321493
> 
> 
> Diffs
> -----
> 
>   libchoqok/ui/choqoktextedit.cpp 4ebe592 
>   libchoqok/ui/postwidget.cpp 4f25834 
> 
> Diff: http://git.reviewboard.kde.org/r/111406/diff/
> 
> 
> Testing
> -------
> 
> Sent a multi-line tweet from Twitter's Web Client and received it correctly in Choqok.
> Also sent a multi-line tweet from Choqok and found it displayed correctly on Twitter's web client.
> 
> 
> File Attachments
> ----------------
> 
> A multiline tweet sent from Twitter web client and displayed in Choqok
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/05/Choqok_multiline.png
> 
> 
> Thanks,
> 
> Ahmed Ibrahim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/choqok-devel/attachments/20130710/076d6376/attachment.html>