Clazy fixes and CI…

Pierre pinaraf at pinaraf.info
Sat Feb 13 16:43:36 GMT 2021


On Saturday, February 13, 2021 3:24:35 PM CET Dan Leinir Turthra Jensen wrote:
> Definitely support that effort as well, they are /much/ nicer to work with
> just all 'round, and even if we can only depend on Qt 5.6, we /can/ depend
> on a sufficiently modern compiler for our code to be less... ancient ;) So
> yeah, definitely go for it :)
> 

Work is in progress then:
https://invent.kde.org/office/calligra/-/merge_requests/16

Some old style remain due to the use of Q_PRIVATE_SLOT.
Do we want to use Qt features marked as, I quote, "for use in private Qt APIs 
only"?
This can be worked around for connect with a lambda, like 
QObject::connect(findStrategy.dialog(), &KFindDialog::okClicked, 
		q, [this]() { q->d->startFind(); });

But if these are to leave and never come back, I'd much rather get rid of them 
and not work around them :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20210213/c993c5a9/attachment.sig>


More information about the calligra-devel mailing list