D24943: Better charset, unicode and image support for RTF files

[Pekka Vuorela]

pvuorela marked an inline comment as done.
pvuorela added inline comments.

INLINE COMMENTS

> davidllewellynjones wrote in PictDestination.cpp:101
> The logic is confusing me here I'm afraid. If there's no `\picwgoal` control word, then `m_goalWidth` will default to 0 and the code above will be skipped. The image width will then be set to 0 on line 104: `m_imageFormat.setWidth( 0 );`. Similarly for height. Is this correct? It feels like it might make more sense for the conditions to be reversed.

Hm, now that you mention it, looks peculiar indeed. Basically it's here overwriting whatever values got read with pic*goal.

REPOSITORY
  R8 Calligra

BRANCH
  unicode

REVISION DETAIL
  https://phabricator.kde.org/D24943

To: pvuorela, davidllewellynjones
Cc: denexter, davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20191029/524f64da/attachment.htm>