<table><tr><td style="">pvuorela marked an inline comment as done.<br />pvuorela added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24943">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24943#inline-141250">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davidllewellynjones</span> wrote in <span style="color: #4b4d51; font-weight: bold;">PictDestination.cpp:101</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The logic is confusing me here I'm afraid. If there's no <tt style="background: #ebebeb; font-size: 13px;">\picwgoal</tt> control word, then <tt style="background: #ebebeb; font-size: 13px;">m_goalWidth</tt> will default to 0 and the code above will be skipped. The image width will then be set to 0 on line 104: <tt style="background: #ebebeb; font-size: 13px;">m_imageFormat.setWidth( 0 );</tt>. Similarly for height. Is this correct? It feels like it might make more sense for the conditions to be reversed.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hm, now that you mention it, looks peculiar indeed. Basically it's here overwriting whatever values got read with pic*goal.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R8 Calligra</div></div></div><br /><div><strong>BRANCH</strong><div><div>unicode</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24943">https://phabricator.kde.org/D24943</a></div></div><br /><div><strong>To: </strong>pvuorela, davidllewellynjones<br /><strong>Cc: </strong>denexter, davidllewellynjones, Calligra-Devel-list, dcaliste, cochise, vandenoever<br /></div>