D19943: Small cleanups for qml components

Pekka Vuorela noreply at phabricator.kde.org
Wed Mar 27 13:23:45 GMT 2019


pvuorela added inline comments.

INLINE COMMENTS

> leinir wrote in Document.cpp:221
> What happens to this signal now?

Nothing, but that's how it used to be. The intention might have been different, but effectively it's two disconnects without actual connection appearing anywhere as far as I can tell. And then again don't think the ::textEditor() getter should really be a place for adjusting any connections anyway.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19943

To: pvuorela, leinir
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20190327/8ee21e92/attachment.htm>


More information about the calligra-devel mailing list