D18466: Fixed calligra crashing when opening remote document

Niccolò Venerandi noreply at phabricator.kde.org
Wed Jan 30 13:28:51 GMT 2019


niccolove marked an inline comment as done.
niccolove added a comment.


  I have some doubts:
  
  - Anything related to "and exiting" does not seem to work. mainWindow->slotFileQuit() does not seem working.
    - --benchmark-loading-show-window should also exit using mainWindow->slotFileQuit(), but it doesn't.
    - Adding mainWindow->slotFileQuit() after a print job does nothing.
    - Calligra does not seem to exit after pdf job, even though job end is connected to mainWindow->slotFileQuit(). (removing the connect does not seem to change anything)
  - The exit after exporting to pdf job seems right, since you should not be able to export multiple files to a single pdf anyway, and you can't print AND export to pdf in the same command.
  - The print command will open a mainWindow for every printing job, so running mainWindow->slotFileQuit() after mainWindow->slotFilePrint() would bring to having no windows open at the end of all jobs.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D18466

To: niccolove, danders
Cc: anthonyfieroni, boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20190130/9fab18de/attachment.htm>


More information about the calligra-devel mailing list