D15412: [filters] Extend table lifetime

Anthony Fieroni noreply at phabricator.kde.org
Thu Sep 13 12:55:04 BST 2018


anthonyfieroni added a comment.


  It can be allocated only in read_tbl but as you can see in bug report, use-after-free is very common to happen.

INLINE COMMENTS

> staniek wrote in MsooXmlDrawingReaderTableMethods.h:40
> This is declaration-only header, so better no, otherwise allocation of a new KoTable is added to all places we include the header, e.g. also PptxXmlSlideReader and in the future.

That isn't a problem, it's initialized at constructor time.

> staniek wrote in DocxXmlDocumentReader.cpp:6082
> Isn't this change in logic?

No

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15412

To: anthonyfieroni, danders, boemann, #calligra:_3.0, staniek
Cc: staniek, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20180913/3cca3f6e/attachment.html>


More information about the calligra-devel mailing list