D15412: [filters] Extend table lifetime
noreply at phabricator.kde.org
Thu Sep 13 12:55:04 BST 2018
anthonyfieroni added a comment.
It can be allocated only in read_tbl but as you can see in bug report, use-after-free is very common to happen.
> staniek wrote in MsooXmlDrawingReaderTableMethods.h:40
> This is declaration-only header, so better no, otherwise allocation of a new KoTable is added to all places we include the header, e.g. also PptxXmlSlideReader and in the future.
That isn't a problem, it's initialized at constructor time.
> staniek wrote in DocxXmlDocumentReader.cpp:6082
> Isn't this change in logic?
To: anthonyfieroni, danders, boemann, #calligra:_3.0, staniek
Cc: staniek, Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the calligra-devel