D15428: [textlayout] Don't enter infinite loop when table is misfit

Anthony Fieroni noreply at phabricator.kde.org
Tue Sep 11 22:05:36 BST 2018


anthonyfieroni added inline comments.

INLINE COMMENTS

> boemann wrote in KoTextLayoutTableArea.cpp:464
> nah this is too aggressive.
> There are definitely cases where setting to 0 is the correct thing to do.
> There might be some times we enter an infinite loop yes, but we need to catch this is some other way

I should see how this would work, because if we reset it to 0 every time it takes same way to parse, as it can see cursor->row is force reset only here.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20180911/65d054b5/attachment.html>


More information about the calligra-devel mailing list