D15428: [textlayout] Don't enter infinite loop when table is misfit

Camilla Boemann noreply at phabricator.kde.org
Tue Sep 11 21:08:24 BST 2018

boemann added inline comments.


> KoTextLayoutNoteArea.cpp:143
> +
> +    if (blockLayoutLine.isValid()) {
> +        d->labelYOffset += blockLayoutLine.ascent();

I'm fine with this change

> KoTextLayoutTableArea.cpp:464
> +            //if we couldn't fit the header rows
> +            //try again don't reset cursor->row or we enter infinite loop
> +            //cursor->row = 0;

nah this is too aggressive.
There are definitely cases where setting to 0 is the correct thing to do.
There might be some times we enter an infinite loop yes, but we need to catch this is some other way

  R8 Calligra


To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20180911/1756511a/attachment-0001.html>

More information about the calligra-devel mailing list