D15428: [textlayout] Don't enter infinite loop when table is misfit

Camilla Boemann noreply at phabricator.kde.org
Tue Dec 18 09:13:00 GMT 2018


boemann added a comment.


  good investigative work, but I fear those tests are way too simple to dare apply the patch.
  
  The table code handles a lot more cases than a simple 2x1 table merged will uncover. I'm a bit surprised of the problems you describe in master - I don't recall any such problems.
  
  I think it is time that we create a lot of unittests. Unittesting table layout is long overdue anyway

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15428

To: anthonyfieroni, #calligra:_3.0, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20181218/5a858f8a/attachment.htm>


More information about the calligra-devel mailing list