D8310: Port Calligra Gemini for 3.x

[Jarosław Staniek]

staniek accepted this revision.
staniek added a comment.
This revision is now accepted and ready to land.


  +1 from me, appeciated the port!
  
  - have not run it
  - have not reviewed the QML part

INLINE COMMENTS

> CMakeLists.txt:3
>  
> +add_definitions("-DUNICODE -D_UNICODE")
> +

Convention:
add_definitions(-DUNICODE -D_UNICODE)

> GeminiMainWindow.cpp:31
> +// Slate mode/docked detection stuff
> +#include <shellapi.h>
> +#define SM_CONVERTIBLESLATEMODE 0x2003

Convention: case-sensitive or clang will warn:

Shellapi.h

> main.cpp:88
>      if (!env.contains("XDG_DATA_DIRS")) {
> -        _putenv_s("XDG_DATA_DIRS", QString(appdir.absolutePath() + "/share").toLocal8Bit());
> +        _putenv_s("XDG_DATA_DIRS", QString(appdir.absolutePath() + "/bin/data").toLocal8Bit());
>          envStringSet.append("XDG_DATA_DIRS ");

Maybe QFile::encodeName instead of toLocal8Bit

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D8310

To: leinir, Calligra-Devel-list, staniek
Cc: staniek, danders, vandenoever
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20171031/ff851f8f/attachment.htm>