<table><tr><td style="">staniek accepted this revision.<br />staniek added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8310" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>+1 from me, appeciated the port!</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">have not run it</li>
<li class="remarkup-list-item">have not reviewed the QML part</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8310#inline-37349" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:3</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">add_definitions("-DUNICODE -D_UNICODE")
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Convention:<br />
add_definitions(-DUNICODE -D_UNICODE)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8310#inline-37350" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GeminiMainWindow.cpp:31</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">// Slate mode/docked detection stuff</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#include</span> <span class="cpf"><shellapi.h></span><span style="color: #304a96"></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#define SM_CONVERTIBLESLATEMODE 0x2003</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Convention: case-sensitive or clang will warn:</p>

<p style="padding: 0; margin: 8px;">Shellapi.h</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8310#inline-37351" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:88</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">env</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span style="color: #766510">"XDG_DATA_DIRS"</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">_putenv_s</span><span class="p">(</span><span style="color: #766510">"XDG_DATA_DIRS"</span><span class="p">,</span> <span class="n">QString</span><span class="p">(</span><span class="n">appdir</span><span class="p">.</span><span class="n">absolutePath</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">"/<span class="bright">share</span>"</span><span class="p">).</span><span class="n">toLocal8Bit</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">_putenv_s</span><span class="p">(</span><span style="color: #766510">"XDG_DATA_DIRS"</span><span class="p">,</span> <span class="n">QString</span><span class="p">(</span><span class="n">appdir</span><span class="p">.</span><span class="n">absolutePath</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span style="color: #766510">"/<span class="bright">bin/data</span>"</span><span class="p">).</span><span class="n">toLocal8Bit</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">envStringSet</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span style="color: #766510">"XDG_DATA_DIRS "</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe QFile::encodeName instead of toLocal8Bit</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R8 Calligra</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8310" rel="noreferrer">https://phabricator.kde.org/D8310</a></div></div><br /><div><strong>To: </strong>leinir, Calligra-Devel-list, staniek<br /><strong>Cc: </strong>staniek, danders, vandenoever<br /></div>