Review Request 129514: [connectionTool] Check dynamic_cast return type

Anthony Fieroni bvbfan at abv.bg
Sat Nov 26 05:50:13 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129514/
-----------------------------------------------------------

(Updated Nov. 26, 2016, 12:50 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra and Camilla Boemann.


Changes
-------

Submitted with commit f3f26b78c7b792e9f5de480d2fd00c98a48d8ba2 by Anthony Fieroni to branch master.


Bugs: 326258
    http://bugs.kde.org/show_bug.cgi?id=326258


Repository: calligra


Description
-------

I can't reproduce these days, but it's safe to check. Correct is based on backtrace in bug report.


Diffs
-----

  plugins/defaultTools/connectionTool/ConnectionTool.cpp 9e3dec6 

Diff: https://git.reviewboard.kde.org/r/129514/diff/


Testing
-------

PS: I manage to work on 2 wishlist, Px (pixels) if can be enabled from settings (i still don't know why it's disabled) and export arrow line in SVG. Other bus looks really outdated.


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20161126/81764081/attachment.htm>


More information about the calligra-devel mailing list