Review Request 129514: [connectionTool] Check dynamic_cast return type

Camilla Boemann cbr at boemann.dk
Fri Nov 25 10:06:08 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129514/#review101109
-----------------------------------------------------------


Ship it!




Ship It!

- Camilla Boemann


On Nov. 21, 2016, 5:42 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129514/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2016, 5:42 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Bugs: 326258
>     http://bugs.kde.org/show_bug.cgi?id=326258
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> I can't reproduce these days, but it's safe to check. Correct is based on backtrace in bug report.
> 
> 
> Diffs
> -----
> 
>   plugins/defaultTools/connectionTool/ConnectionTool.cpp 9e3dec6 
> 
> Diff: https://git.reviewboard.kde.org/r/129514/diff/
> 
> 
> Testing
> -------
> 
> PS: I manage to work on 2 wishlist, Px (pixels) if can be enabled from settings (i still don't know why it's disabled) and export arrow line in SVG. Other bus looks really outdated.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20161125/4c929c93/attachment.htm>


More information about the calligra-devel mailing list